All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Michal Hocko <mhocko@kernel.org>, Li Zefan <lizefan@huawei.com>,
	Roman Gushchin <guro@fb.com>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Greg Thelen <gthelen@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH] mm: memcontrol: memory+swap accounting for cgroup-v2
Date: Tue, 19 Dec 2017 07:24:44 -0800	[thread overview]
Message-ID: <20171219152444.GP3919388@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CALvZod5jU9vPoJaf44TVT0_HQpEESiELJU5MD_DDRbcOkPNQbg@mail.gmail.com>

Hello,

On Tue, Dec 19, 2017 at 07:12:19AM -0800, Shakeel Butt wrote:
> Yes, there are pros & cons, therefore we should give users the option
> to select the API that is better suited for their use-cases and

Heh, that's not how API decisions should be made.  The long term
outcome would be really really bad.

> environment. Both approaches are not interchangeable. We use memsw
> internally for use-cases I mentioned in commit message. This is one of
> the main blockers for us to even consider cgroup-v2 for memory
> controller.

Let's concentrate on the use case.  I couldn't quite understand what
was missing from your description.  You said that it'd make things
easier for the centralized monitoring system which isn't really a
description of a use case.  Can you please go into more details
focusing on the eventual goals (rather than what's currently
implemented)?

Thanks.

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Michal Hocko <mhocko@kernel.org>, Li Zefan <lizefan@huawei.com>,
	Roman Gushchin <guro@fb.com>,
	Vladimir Davydov <vdavydov.dev@gmail.com>,
	Greg Thelen <gthelen@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Hugh Dickins <hughd@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Cgroups <cgroups@vger.kernel.org>,
	linux-doc@vger.kernel.org
Subject: Re: [RFC PATCH] mm: memcontrol: memory+swap accounting for cgroup-v2
Date: Tue, 19 Dec 2017 07:24:44 -0800	[thread overview]
Message-ID: <20171219152444.GP3919388@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CALvZod5jU9vPoJaf44TVT0_HQpEESiELJU5MD_DDRbcOkPNQbg@mail.gmail.com>

Hello,

On Tue, Dec 19, 2017 at 07:12:19AM -0800, Shakeel Butt wrote:
> Yes, there are pros & cons, therefore we should give users the option
> to select the API that is better suited for their use-cases and

Heh, that's not how API decisions should be made.  The long term
outcome would be really really bad.

> environment. Both approaches are not interchangeable. We use memsw
> internally for use-cases I mentioned in commit message. This is one of
> the main blockers for us to even consider cgroup-v2 for memory
> controller.

Let's concentrate on the use case.  I couldn't quite understand what
was missing from your description.  You said that it'd make things
easier for the centralized monitoring system which isn't really a
description of a use case.  Can you please go into more details
focusing on the eventual goals (rather than what's currently
implemented)?

Thanks.

-- 
tejun

  reply	other threads:[~2017-12-19 15:24 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-19  0:01 [RFC PATCH] mm: memcontrol: memory+swap accounting for cgroup-v2 Shakeel Butt
2017-12-19  0:01 ` Shakeel Butt
2017-12-19 12:49 ` Michal Hocko
2017-12-19 12:49   ` Michal Hocko
2017-12-19 12:49   ` Michal Hocko
2017-12-19 15:12   ` Shakeel Butt
2017-12-19 15:12     ` Shakeel Butt
2017-12-19 15:24     ` Tejun Heo [this message]
2017-12-19 15:24       ` Tejun Heo
2017-12-19 17:23       ` Shakeel Butt
2017-12-19 17:23         ` Shakeel Butt
2017-12-19 17:33         ` Tejun Heo
2017-12-19 17:33           ` Tejun Heo
     [not found]           ` <20171219173354.GQ3919388-4dN5La/x3IkLX0oZNxdnEQ2O0Ztt9esIQQ4Iyu8u01E@public.gmane.org>
2017-12-19 18:25             ` Shakeel Butt
2017-12-19 18:25               ` Shakeel Butt
2017-12-19 18:25               ` Shakeel Butt
2017-12-19 21:41               ` Tejun Heo
2017-12-19 21:41                 ` Tejun Heo
2017-12-19 22:39                 ` Shakeel Butt
2017-12-19 22:39                   ` Shakeel Butt
     [not found]                   ` <CALvZod5XRhXc3XrQw50Jw_OpRQB2iCCbgG-NMDCa8xRmGNdLrw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-20 19:37                     ` Tejun Heo
2017-12-20 19:37                       ` Tejun Heo
2017-12-20 19:37                       ` Tejun Heo
2017-12-20 20:15                       ` Shakeel Butt
2017-12-20 20:15                         ` Shakeel Butt
2017-12-20 20:27                         ` Shakeel Butt
2017-12-20 20:27                           ` Shakeel Butt
2017-12-20 23:36                         ` Tejun Heo
2017-12-20 23:36                           ` Tejun Heo
2017-12-21  1:15                           ` Shakeel Butt
2017-12-21  1:15                             ` Shakeel Butt
2017-12-21 13:37                             ` Tejun Heo
2017-12-21 13:37                               ` Tejun Heo
2017-12-21 15:22                               ` Shakeel Butt
2017-12-21 15:22                                 ` Shakeel Butt
2017-12-21 15:33                                 ` Shakeel Butt
2017-12-21 15:33                                   ` Shakeel Butt
     [not found]                                 ` <CALvZod432hzxPZgAypjPsZ33Z==0MxmMdPM3bEBZMea-7GFAVw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-21 17:29                                   ` Tejun Heo
2017-12-21 17:29                                     ` Tejun Heo
2017-12-21 17:29                                     ` Tejun Heo
2017-12-27 19:49                                     ` Shakeel Butt
2017-12-27 19:49                                       ` Shakeel Butt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171219152444.GP3919388@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=gthelen@google.com \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.