Re: [PATCH] nfsd4: permit layoutget of executable-only files

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Dec 19, 2017 at 12:10:48PM -0500, Benjamin Coddington wrote:
> On 19 Dec 2017, at 11:00, Trond Myklebust wrote:
> 
> > On Tue, 2017-12-19 at 10:43 -0500, J. Bruce Fields wrote:
> >> On Tue, Dec 19, 2017 at 09:35:25AM -0500, Benjamin Coddington wrote:
> >>> Clients must be able to read a file in order to execute it, and for
> >>> pNFS
> >>> that means the client needs to be able to perform a LAYOUTGET on
> >>> the file.
> >>>
> >>> This behavior for executable-only files was added for OPEN in
> >>> commit
> >>> a043226bc140 "nfsd4: permit read opens of executable-only files".
> >>>
> >>> This fixes up xfstests generic/126 on block/scsi layouts.
> >>
> >> Thanks, applied.  So the server was returning NFS4ERR_ACCESS and the
> >> client was returning that to the application?  I was wondering for a
> >> moment whether the client should instead try falling back to MDS IO,
> >> but.... But I don't think that makes sense.  The client's probably
> >> correct to interpret ACCESS as just meaning that user can't read the
> >> file.  The server has plenty of other errors to choose from if it
> >> just
> >> wants to deny the layout for some reason.  OK.
> >>
> >
> > There are several errors which can be returned by LAYOUTGET, and which
> > the client will pass back to the application. NFS4ERR_ACCESS is one.
> 
> And just to be perfectly clear, yes, that's what I see.

Got it, thanks.b

--b.