From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Subject: [1/2] usb: musb: un-break davinci glue layer
From: Bin Liu <b-liu@ti.com>
Message-Id: <20171219172220.GD14090@uda0271908>
Date: Tue, 19 Dec 2017 11:22:20 -0600
To: Alejandro Mery <amery@hanoverdisplays.com>
Cc: linux-usb@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
List-ID: <linux-usb.vger.kernel.org>

SGkgQWxlamFuZHJvLAoKT24gRnJpLCBEZWMgMDgsIDIwMTcgYXQgMDc6MjM6NTRQTSArMDAwMCwg
QWxlamFuZHJvIE1lcnkgd3JvdGU6Cj4gTVVTQidzIGRhdmluY2kgZ2x1ZSB3YXMgbWFkZSB0byBk
ZXBlbmQgb24gQlJPS0VOIGJ5IEZlbGlwZSBCYWxiaSBiYWNrIGluCj4gMjAxMyBiZWNhdXNlIG9m
IGxhY2sgb2YgYWN0aXZlIGRldmVsb3BtZW50LiBuZWVkZWQgY2hhbmdlcyB3ZXJlIGFjdHVhbGx5
IHRyaXZpYWwKPiAKPiBGaXhlczogNzg3ZjU2MjdiZWM4ICh1c2I6IG11c2I6IG1ha2UgZGF2aW5j
aSBhbmQgZGE4eHggZ2x1ZXMgZGVwZW5kIG9uIEJST0tFTikKPiBTaWduZWQtb2ZmLWJ5OiBBbGVq
YW5kcm8gTWVyeSA8YW1lcnlAaGFub3ZlcmRpc3BsYXlzLmNvbT4KClRoYW5rcyBmb3IgdGhlIGVm
Zm9ydCB0byByZS1lbmFibGUgdGhpcyBkcml2ZXIuIEJ1dCBkdWUgdG8gbGFjayBvZgpkZXZlbG9w
bWVudCwgb3RoZXIgdGhhbiB0aGUgcGh5IGFuZCBmaWZvIG1vZGUgd2hpY2ggeW91IHRyeSB0byBm
aXggd2l0aAp0aGVzZSB0d28gcGF0Y2hlcywgdGhlIGRyaXZlciBzdGlsbCBkb2Vzbid0IGZpdCBp
biB0aGUgY3VycmVudCBkcml2ZXIKZnJhbWV3b3JrLCBmb3IgZXhhbXBsZSwKCi0gdGhlIGRyaXZl
ciBkZXBlbmRzIG9uIG1hY2gvIGhlYWRlciBmb3IgQ1BVIGFuZCBib2FyZCB0eXBlOwotIGNsayBj
b250cm9sIGlzIG5vdCBzZXBhcmF0ZWQ7Ci0gZ3BpbyBjb250cm9sIHZidXMgc2hvdWxkIHVzZSBl
eHRjb24gZHJpdmVyOwoKU28gSSBmZWVsIGl0IGlzIG5vdCByZWFkeSB0byB1bi1icm9rZW4gaXQg
eWV0LCB1bmxlc3Mgb3RoZXJzIGhhdmUKZGlmZmVyZW50IG9waW5pb24uCgpCdXQgSSBjb3VsZCB0
YWtlIHRoZXNlIHR3byBwYXRjaGVzIGlmIG5vdCByZW1vdmUgQlJPS0VOIGZyb20gS2NvbmZpZy4K
ClJlZ2FyZHMsCi1CaW4uCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0
aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2Ug
dG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRw
Oi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK

From mboxrd@z Thu Jan  1 00:00:00 1970
From: b-liu@ti.com (Bin Liu)
Date: Tue, 19 Dec 2017 11:22:20 -0600
Subject: [PATCH 1/2] usb: musb: un-break davinci glue layer
In-Reply-To: <20171208192355.32735-1-amery@hanoverdisplays.com>
References: <20171208192355.32735-1-amery@hanoverdisplays.com>
Message-ID: <20171219172220.GD14090@uda0271908>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Alejandro,

On Fri, Dec 08, 2017 at 07:23:54PM +0000, Alejandro Mery wrote:
> MUSB's davinci glue was made to depend on BROKEN by Felipe Balbi back in
> 2013 because of lack of active development. needed changes were actually trivial
> 
> Fixes: 787f5627bec8 (usb: musb: make davinci and da8xx glues depend on BROKEN)
> Signed-off-by: Alejandro Mery <amery@hanoverdisplays.com>

Thanks for the effort to re-enable this driver. But due to lack of
development, other than the phy and fifo mode which you try to fix with
these two patches, the driver still doesn't fit in the current driver
framework, for example,

- the driver depends on mach/ header for CPU and board type;
- clk control is not separated;
- gpio control vbus should use extcon driver;

So I feel it is not ready to un-broken it yet, unless others have
different opinion.

But I could take these two patches if not remove BROKEN from Kconfig.

Regards,
-Bin.