From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bart Van Assche <Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org>
Subject: [PATCH rdma-core] srp_daemon: Remove duplicate sync_res shutdown
Date: Tue, 19 Dec 2017 14:16:01 -0700 [thread overview]
Message-ID: <20171219211601.GA27412@ziepe.ca> (raw)
The very first thing free_res does is the same lock/signal/unlock
sequence, so there is no reason to open code it before calling
free_res.
Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
srp_daemon/srp_daemon.c | 4 ----
1 file changed, 4 deletions(-)
Noticed while looking at honli's patch.. Didn't make a PR.
diff --git a/srp_daemon/srp_daemon.c b/srp_daemon/srp_daemon.c
index cec36db2e0f12e..a1798558373490 100644
--- a/srp_daemon/srp_daemon.c
+++ b/srp_daemon/srp_daemon.c
@@ -2074,10 +2074,6 @@ static int ibsrpdm(int argc, char *argv[])
pr_err("Querying SRP targets failed\n");
assert(res->sync_res);
- pthread_mutex_lock(&res->sync_res->retry_mutex);
- res->sync_res->stop_threads = 1;
- pthread_cond_signal(&res->sync_res->retry_cond);
- pthread_mutex_unlock(&res->sync_res->retry_mutex);
free_res(res);
umad_done:
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2017-12-19 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 21:16 Jason Gunthorpe [this message]
[not found] ` <20171219211601.GA27412-uk2M96/98Pc@public.gmane.org>
2017-12-19 21:21 ` [PATCH rdma-core] srp_daemon: Remove duplicate sync_res shutdown Bart Van Assche
[not found] ` <1513718464.2535.16.camel-Sjgp3cTcYWE@public.gmane.org>
2017-12-19 21:28 ` Jason Gunthorpe
[not found] ` <20171219212818.GG14800-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-19 21:33 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219211601.GA27412@ziepe.ca \
--to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=Bart.VanAssche-Sjgp3cTcYWE@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.