From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Rabeeh Khoury <rabeeh@solid-run.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Baruch Siach <baruch@tkos.co.il>,
linux-rtc@vger.kernel.org,
"nadavh@marvell.com" <nadavh@marvell.com>
Subject: Re: Armada RTC power up reset
Date: Wed, 20 Dec 2017 18:02:00 +0100 [thread overview]
Message-ID: <20171220170200.GA15162@piout.net> (raw)
In-Reply-To: <CA+j0otm7EeY034nXj8ESYwSaP3JPuV7OoUS+1+GkQ7eOEAOCuw@mail.gmail.com>
On 11/12/2017 at 20:14:00 +0200, Rabeeh Khoury wrote:
> The first; sets the values to a know good state (including time=0) on it's
> probe() -
> https://pastebin.com/ubqwEBBM
>
No, as explained that would be bad for userspace as it will have now way
to know whether the time is correct or not (you may as well not have any
RTC at all).
> Second return -EPERM on an uninitialized RTC until first write resets it's
> values to a known condition on first write (as Gregory suggest) -
> https://pastebin.com/r7sydF8G
>
-EINVAL is the proper error code for an uninitialized RTC but yes, that
would be the idea.
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-12-20 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 9:40 Armada RTC power up reset Baruch Siach
2017-12-01 17:10 ` Gregory CLEMENT
2017-12-11 12:46 ` Rabeeh Khoury
2017-12-11 16:08 ` Alexandre Belloni
2017-12-11 18:14 ` Rabeeh Khoury
2017-12-20 17:02 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220170200.GA15162@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=baruch@tkos.co.il \
--cc=gregory.clement@free-electrons.com \
--cc=linux-rtc@vger.kernel.org \
--cc=nadavh@marvell.com \
--cc=rabeeh@solid-run.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.