All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Ido Schimmel <idosch@mellanox.com>,
	Netdev <netdev@vger.kernel.org>,
	David Miller <davem@davemloft.net>,
	"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
	David Ahern <dsahern@gmail.com>,
	Fengguang Wu <fengguang.wu@intel.com>,
	mlxsw@mellanox.com
Subject: Re: [PATCH net v2] ipv4: Fix use-after-free when flushing FIB tables
Date: Wed, 20 Dec 2017 19:41:17 +0200	[thread overview]
Message-ID: <20171220174117.GA11654@splinter> (raw)
In-Reply-To: <CAKgT0UcJD=OYM5qEdGv-vvpv3EcAyRVTWJ34MWshrxABvFUWGw@mail.gmail.com>

On Wed, Dec 20, 2017 at 07:32:21AM -0800, Alexander Duyck wrote:
> I think we might want even more description here. Specifically why
> reversing the order allows local to be destroyed before main. I was
> thinking something along the lines of:
> 
> Destroy the tables in reverse order to guarantee that the local table,
> ID 255, is destroyed before main table, ID 254. This is necessary as
> local may contain references to data contained in main.

Sent v3:
http://patchwork.ozlabs.org/patch/851564/

Thanks

      reply	other threads:[~2017-12-20 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20  8:51 [PATCH net v2] ipv4: Fix use-after-free when flushing FIB tables Ido Schimmel
2017-12-20 15:32 ` Alexander Duyck
2017-12-20 17:41   ` Ido Schimmel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220174117.GA11654@splinter \
    --to=idosch@idosch.org \
    --cc=alexander.duyck@gmail.com \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=fengguang.wu@intel.com \
    --cc=idosch@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.