All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: ben@skyportsystems.com, qemu-devel@nongnu.org, yan@daynix.com,
	eswierk@skyportsystems.com, lprosek@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property
Date: Wed, 20 Dec 2017 19:24:20 +0200	[thread overview]
Message-ID: <20171220192116-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20171213100712.GA16782@stefanha-x1.localdomain>

On Wed, Dec 13, 2017 at 10:07:12AM +0000, Stefan Hajnoczi wrote:
> On Wed, Dec 13, 2017 at 12:26:44AM -0800, Ben Warren via Qemu-devel wrote:
> > From: Ben Warren <ben@skyportsystems.com>
> > 
> > Now that virtio-win guest drivers provided by non-Redhat vendors need to
> > use a different Subsystem Vendor ID value, a way is needed to set this
> > parameter on the host.  This works with all of the PCI-based devices,
> > such as NetKVM, viostor, vioscsi, vioserial and balloon.
> > 
> > Signed-off-by: Ben Warren <ben@skyportsystems.com>
> > ---
> >  hw/virtio/virtio-pci.c | 5 +++++
> >  hw/virtio/virtio-pci.h | 1 +
> >  2 files changed, 6 insertions(+)
> 
> Is it possible to put this property in hw/pci/pci.c:pci_props[] so that
> users can override the Subsystem Vendor ID for any PCI adapter, not just
> virtio-pci?

The difficulty is that some devices override the ID you would set,
and there's no way for management to find out.
So I think virtio is preferable for now.

  reply	other threads:[~2017-12-20 17:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-13  8:26 [Qemu-devel] [PATCH] virtio-pci: Add subsystem-vendor-id property ben
2017-12-13 10:07 ` Stefan Hajnoczi
2017-12-20 17:24   ` Michael S. Tsirkin [this message]
2018-05-07 22:41     ` Benjamin Warren
2017-12-20  4:27 ` Michael S. Tsirkin
2017-12-20  5:11   ` Ben Warren
2017-12-20 14:11     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220192116-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=ben@skyportsystems.com \
    --cc=eswierk@skyportsystems.com \
    --cc=lprosek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=yan@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.