All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Lucas De Marchi <lucas.demarchi@intel.com>,
	Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Subject: Re: [PATCH] drm/i915/cfl: Adding more Coffee Lake PCI IDs.
Date: Wed, 20 Dec 2017 11:24:59 -0800	[thread overview]
Message-ID: <20171220192459.t2oooh5zc6omuko2@intel.com> (raw)
In-Reply-To: <20171220191547.GD4484@intel.com>

On Wed, Dec 20, 2017 at 07:15:47PM +0000, Anusha Srivatsa wrote:
> On Wed, Dec 20, 2017 at 10:29:19AM -0800, Rodrigo Vivi wrote:
> > Spec has been updated with more reserved IDs for existent SKUs.
> > 
> > Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> > Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: Anuj Phogat <anuj.phogat@gmail.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> The IDs match with Spec.
> 
> Reviewed-by: Anusha Srivatsa<anusha.srivatsa@intel.com>

Merged, thanks.

> > ---
> >  drivers/gpu/drm/i915/i915_pci.c |  2 ++
> >  include/drm/i915_pciids.h       | 28 ++++++++++++++++++++++------
> >  2 files changed, 24 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index fa67d3dde20e..36d48422b475 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -633,6 +633,8 @@ static const struct pci_device_id pciidlist[] = {
> >  	INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
> >  	INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
> >  	INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> > +	INTEL_CFL_U_GT1_IDS(&intel_coffeelake_gt1_info),
> > +	INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info),
> >  	INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info),
> >  	INTEL_CNL_U_GT2_IDS(&intel_cannonlake_gt2_info),
> >  	INTEL_CNL_Y_GT2_IDS(&intel_cannonlake_gt2_info),
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index c65e4489006d..5db0458dd832 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -373,29 +373,45 @@
> >  /* CFL S */
> >  #define INTEL_CFL_S_GT1_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x3E90, info), /* SRV GT1 */ \
> > -	INTEL_VGA_DEVICE(0x3E93, info)  /* SRV GT1 */
> > +	INTEL_VGA_DEVICE(0x3E93, info), /* SRV GT1 */ \
> > +	INTEL_VGA_DEVICE(0x3E99, info)  /* SRV GT1 */
> >  
> >  #define INTEL_CFL_S_GT2_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x3E91, info), /* SRV GT2 */ \
> >  	INTEL_VGA_DEVICE(0x3E92, info), /* SRV GT2 */ \
> > -	INTEL_VGA_DEVICE(0x3E96, info)  /* SRV GT2 */
> > +	INTEL_VGA_DEVICE(0x3E96, info), /* SRV GT2 */ \
> > +	INTEL_VGA_DEVICE(0x3E9A, info)  /* SRV GT2 */
> >  
> >  /* CFL H */
> >  #define INTEL_CFL_H_GT2_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
> >  	INTEL_VGA_DEVICE(0x3E94, info)  /* Halo GT2 */
> >  
> > -/* CFL U */
> > +/* CFL U GT1 */
> > +#define INTEL_CFL_U_GT1_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x3EA1, info), \
> > +	INTEL_VGA_DEVICE(0x3EA4, info)
> > +
> > +/* CFL U GT2 */
> > +#define INTEL_CFL_U_GT2_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x3EA0, info), \
> > +	INTEL_VGA_DEVICE(0x3EA3, info), \
> > +	INTEL_VGA_DEVICE(0x3EA9, info)
> > +
> > +/* CFL U GT3 */
> >  #define INTEL_CFL_U_GT3_IDS(info) \
> > +	INTEL_VGA_DEVICE(0x3EA2, info), /* ULT GT3 */ \
> > +	INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
> >  	INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
> > -	INTEL_VGA_DEVICE(0x3EA8, info), /* ULT GT3 */ \
> > -	INTEL_VGA_DEVICE(0x3EA5, info)  /* ULT GT3 */
> > +	INTEL_VGA_DEVICE(0x3EA8, info)  /* ULT GT3 */
> >  
> > -#define INTEL_CFL_IDS(info) \
> > +#define INTEL_CFL_IDS(info)	   \
> >  	INTEL_CFL_S_GT1_IDS(info), \
> >  	INTEL_CFL_S_GT2_IDS(info), \
> >  	INTEL_CFL_H_GT2_IDS(info), \
> > +	INTEL_CFL_U_GT1_IDS(info), \
> > +	INTEL_CFL_U_GT2_IDS(info), \
> >  	INTEL_CFL_U_GT3_IDS(info)
> >  
> >  /* CNL U 2+2 */
> > -- 
> > 2.13.6
> > 
> 
> -- 
> Anusha Srivatsa
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-12-20 19:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 18:29 [PATCH] drm/i915/cfl: Adding more Coffee Lake PCI IDs Rodrigo Vivi
2017-12-20 18:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-20 19:15 ` [PATCH] " Anusha Srivatsa
2017-12-20 19:24   ` Rodrigo Vivi [this message]
2017-12-20 20:27 ` ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171220192459.t2oooh5zc6omuko2@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=anusha.srivatsa@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.