From: Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: "Ognjen Galić" <smclt30p-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Platform Driver
<platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rafael J. Wysocki"
<rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Henrique de Moraes Holschuh
<ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
Linux PM <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Robert Moore
<robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Sebastian Reichel <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
ACPI Devel Maling List
<linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Lv Zheng <lv.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
devel-E0kO6a4B6psdnm+yROfE0A@public.gmane.org,
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Andy Shevchenko <andy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 1/3 v6] battery: Add the battery hooking API
Date: Wed, 20 Dec 2017 13:58:09 -0800 [thread overview]
Message-ID: <20171220215809.GB14966@fury> (raw)
In-Reply-To: <CALgTWSvEg3EfjSJqAp5nRuxRceBpg92=x3FPFEW9PThBmizQEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Dec 20, 2017 at 10:23:30PM +0100, Ognjen Galić wrote:
> On 20/12/2017, Darren Hart <dvhart@infradead.org> wrote:
> > On Wed, Dec 20, 2017 at 03:30:18PM +0100, Ognjen Galić wrote:
> >> On 18/12/2017, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >> > Also, what if someone attempts to add a hook when the ACPI battery
> >
> >> > module is not loaded? Will that still work?
> >>
> >> The module that requests the hooks will fail to load with the following
> >>
> >> > [ 149.259127] thinkpad_acpi: Unknown symbol battery_hook_register (err
> >> > 0)
> >> > [ 149.259158] thinkpad_acpi: Unknown symbol battery_hook_unregister
> >> > (err 0)
> >
> > Will a synchronous request_module() address this concern?
> >
>
> I don't know, that check seems like a pre-load check. Like metadata
> checking about
> the module. modprobe handles the module loading just fine.
Read to quick trying to catch up and misunderstood the problem. Please
disregard.
--
Darren Hart
VMware Open Source Technology Center
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
next prev parent reply other threads:[~2017-12-20 21:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 16:56 [PATCH 1/3 v6] battery: Add the battery hooking API Ognjen Galic
2017-12-18 18:04 ` [Devel] " Rafael J. Wysocki
2017-12-18 18:04 ` Rafael J. Wysocki
2017-12-20 14:30 ` Ognjen Galić
2017-12-20 21:17 ` Darren Hart
2017-12-20 21:23 ` Ognjen Galić
[not found] ` <CALgTWSvEg3EfjSJqAp5nRuxRceBpg92=x3FPFEW9PThBmizQEA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-20 21:58 ` Darren Hart [this message]
2017-12-20 19:32 ` Ognjen Galic
2017-12-20 19:42 ` Ognjen Galić
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171220215809.GB14966@fury \
--to=dvhart-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
--cc=andy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=devel-E0kO6a4B6psdnm+yROfE0A@public.gmane.org \
--cc=ibm-acpi-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lv.zheng-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rafael-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robert.moore-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=smclt30p-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.