From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Thu, 21 Dec 2017 09:48:02 +0000 Subject: Re: [RFC PATCH v2 00/13] Kernel based bootsplash Message-Id: <20171221094802.GR26573@phenom.ffwll.local> List-Id: References: <20171213194755.3409-1-mstaudt@suse.de> In-Reply-To: <20171213194755.3409-1-mstaudt@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Max Staudt Cc: linux-fbdev@vger.kernel.org, michal@markovi.net, b.zolnierkie@samsung.com, sndirsch@suse.com, oneukum@suse.com, tiwai@suse.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, philm@manjaro.org, bernhard.rosenkranzer@linaro.org On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: > Dear fbdev and fbcon developers, > > Thank you very much for your input for the first patch series. > > I've included your feedback into this second roll, and kindly ask for > your opinion on the new patch series. > > > Changes from v1 to v2: > > + Added a user space tool to create splash theme files > + Bumped the file format version: > - Larger structs for easy future expansion > - 2-byte corner offset > - Offset either from corner or from center > - Fixed padding before header->frame_ms > + Moved bootsplash_file.h to uapi/linux > + Merged several patches > + Theme files are now loaded via request_firmware() > + sysfs hook to allow loading of theme files via request_firmware() > + Dropped the .enable cmdline option and the default file name. > The splash will be shown as soon as a file is specified. > + Dropped custom workqueue in favor of the kernel queue > and cancel_delayed_work_sync() > + Marked loaded data as const, and load/enable it atomically > + Reduced global state by moving data into other structures > + EXPORT_SYMBOL_GPL for fbcon_set_dummyops() > + Atomic and barrier for splash enabled state instead of spinlock > + Reduced warnings to infos > + Rate limited printk > + Changed the multi-line comment layout to kernel style > + Simplified the file headers > + reST-ed the documentation Ok, here's my expectation: - fix plymouth and driver loading If the plymouth maintainer tells me that's impossible, I'll look at this again. And no, this does not require killing drivers with SIGBUS, at least not with drm. Meanwhile I don't think this RFC makes sense to be merged. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH v2 00/13] Kernel based bootsplash Date: Thu, 21 Dec 2017 10:48:02 +0100 Message-ID: <20171221094802.GR26573@phenom.ffwll.local> References: <20171213194755.3409-1-mstaudt@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6982D6E077 for ; Thu, 21 Dec 2017 09:48:07 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id b76so14689230wmg.1 for ; Thu, 21 Dec 2017 01:48:07 -0800 (PST) Content-Disposition: inline In-Reply-To: <20171213194755.3409-1-mstaudt@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Max Staudt Cc: linux-fbdev@vger.kernel.org, michal@markovi.net, b.zolnierkie@samsung.com, sndirsch@suse.com, oneukum@suse.com, tiwai@suse.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, philm@manjaro.org, bernhard.rosenkranzer@linaro.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBEZWMgMTMsIDIwMTcgYXQgMDg6NDc6NDJQTSArMDEwMCwgTWF4IFN0YXVkdCB3cm90 ZToKPiBEZWFyIGZiZGV2IGFuZCBmYmNvbiBkZXZlbG9wZXJzLAo+IAo+IFRoYW5rIHlvdSB2ZXJ5 IG11Y2ggZm9yIHlvdXIgaW5wdXQgZm9yIHRoZSBmaXJzdCBwYXRjaCBzZXJpZXMuCj4gCj4gSSd2 ZSBpbmNsdWRlZCB5b3VyIGZlZWRiYWNrIGludG8gdGhpcyBzZWNvbmQgcm9sbCwgYW5kIGtpbmRs eSBhc2sgZm9yCj4geW91ciBvcGluaW9uIG9uIHRoZSBuZXcgcGF0Y2ggc2VyaWVzLgo+IAo+IAo+ IENoYW5nZXMgZnJvbSB2MSB0byB2MjoKPiAKPiAgKyBBZGRlZCBhIHVzZXIgc3BhY2UgdG9vbCB0 byBjcmVhdGUgc3BsYXNoIHRoZW1lIGZpbGVzCj4gICsgQnVtcGVkIHRoZSBmaWxlIGZvcm1hdCB2 ZXJzaW9uOgo+ICAgICAtIExhcmdlciBzdHJ1Y3RzIGZvciBlYXN5IGZ1dHVyZSBleHBhbnNpb24K PiAgICAgLSAyLWJ5dGUgY29ybmVyIG9mZnNldAo+ICAgICAtIE9mZnNldCBlaXRoZXIgZnJvbSBj b3JuZXIgb3IgZnJvbSBjZW50ZXIKPiAgICAgLSBGaXhlZCBwYWRkaW5nIGJlZm9yZSBoZWFkZXIt PmZyYW1lX21zCj4gICsgTW92ZWQgYm9vdHNwbGFzaF9maWxlLmggdG8gdWFwaS9saW51eAo+ICAr IE1lcmdlZCBzZXZlcmFsIHBhdGNoZXMKPiAgKyBUaGVtZSBmaWxlcyBhcmUgbm93IGxvYWRlZCB2 aWEgcmVxdWVzdF9maXJtd2FyZSgpCj4gICsgc3lzZnMgaG9vayB0byBhbGxvdyBsb2FkaW5nIG9m IHRoZW1lIGZpbGVzIHZpYSByZXF1ZXN0X2Zpcm13YXJlKCkKPiAgKyBEcm9wcGVkIHRoZSAuZW5h YmxlIGNtZGxpbmUgb3B0aW9uIGFuZCB0aGUgZGVmYXVsdCBmaWxlIG5hbWUuCj4gICAgVGhlIHNw bGFzaCB3aWxsIGJlIHNob3duIGFzIHNvb24gYXMgYSBmaWxlIGlzIHNwZWNpZmllZC4KPiAgKyBE cm9wcGVkIGN1c3RvbSB3b3JrcXVldWUgaW4gZmF2b3Igb2YgdGhlIGtlcm5lbCBxdWV1ZQo+ICAg IGFuZCBjYW5jZWxfZGVsYXllZF93b3JrX3N5bmMoKQo+ICArIE1hcmtlZCBsb2FkZWQgZGF0YSBh cyBjb25zdCwgYW5kIGxvYWQvZW5hYmxlIGl0IGF0b21pY2FsbHkKPiAgKyBSZWR1Y2VkIGdsb2Jh bCBzdGF0ZSBieSBtb3ZpbmcgZGF0YSBpbnRvIG90aGVyIHN0cnVjdHVyZXMKPiAgKyBFWFBPUlRf U1lNQk9MX0dQTCBmb3IgZmJjb25fc2V0X2R1bW15b3BzKCkKPiAgKyBBdG9taWMgYW5kIGJhcnJp ZXIgZm9yIHNwbGFzaCBlbmFibGVkIHN0YXRlIGluc3RlYWQgb2Ygc3BpbmxvY2sKPiAgKyBSZWR1 Y2VkIHdhcm5pbmdzIHRvIGluZm9zCj4gICsgUmF0ZSBsaW1pdGVkIHByaW50awo+ICArIENoYW5n ZWQgdGhlIG11bHRpLWxpbmUgY29tbWVudCBsYXlvdXQgdG8ga2VybmVsIHN0eWxlCj4gICsgU2lt cGxpZmllZCB0aGUgZmlsZSBoZWFkZXJzCj4gICsgcmVTVC1lZCB0aGUgZG9jdW1lbnRhdGlvbgoK T2ssIGhlcmUncyBteSBleHBlY3RhdGlvbjoKCi0gZml4IHBseW1vdXRoIGFuZCBkcml2ZXIgbG9h ZGluZwoKSWYgdGhlIHBseW1vdXRoIG1haW50YWluZXIgdGVsbHMgbWUgdGhhdCdzIGltcG9zc2li bGUsIEknbGwgbG9vayBhdCB0aGlzCmFnYWluLiBBbmQgbm8sIHRoaXMgZG9lcyBub3QgcmVxdWly ZSBraWxsaW5nIGRyaXZlcnMgd2l0aCBTSUdCVVMsIGF0IGxlYXN0Cm5vdCB3aXRoIGRybS4gTWVh bndoaWxlIEkgZG9uJ3QgdGhpbmsgdGhpcyBSRkMgbWFrZXMgc2Vuc2UgdG8gYmUgbWVyZ2VkLgot RGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3Jh dGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752387AbdLUJsL (ORCPT ); Thu, 21 Dec 2017 04:48:11 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:39057 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbdLUJsG (ORCPT ); Thu, 21 Dec 2017 04:48:06 -0500 X-Google-Smtp-Source: ACJfBouYBIP9FrqtRT6bjfXw2qBUAtVFYliAVnfVghf15Hgu1tRNwW5HNgN/ZH0RGjOn3AW1uwBGdQ== Date: Thu, 21 Dec 2017 10:48:02 +0100 From: Daniel Vetter To: Max Staudt Cc: b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, michal@markovi.net, sndirsch@suse.com, oneukum@suse.com, tiwai@suse.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.rosenkranzer@linaro.org, philm@manjaro.org Subject: Re: [RFC PATCH v2 00/13] Kernel based bootsplash Message-ID: <20171221094802.GR26573@phenom.ffwll.local> Mail-Followup-To: Max Staudt , b.zolnierkie@samsung.com, linux-fbdev@vger.kernel.org, michal@markovi.net, sndirsch@suse.com, oneukum@suse.com, tiwai@suse.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, bernhard.rosenkranzer@linaro.org, philm@manjaro.org References: <20171213194755.3409-1-mstaudt@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213194755.3409-1-mstaudt@suse.de> X-Operating-System: Linux phenom 4.13.0-1-amd64 User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 13, 2017 at 08:47:42PM +0100, Max Staudt wrote: > Dear fbdev and fbcon developers, > > Thank you very much for your input for the first patch series. > > I've included your feedback into this second roll, and kindly ask for > your opinion on the new patch series. > > > Changes from v1 to v2: > > + Added a user space tool to create splash theme files > + Bumped the file format version: > - Larger structs for easy future expansion > - 2-byte corner offset > - Offset either from corner or from center > - Fixed padding before header->frame_ms > + Moved bootsplash_file.h to uapi/linux > + Merged several patches > + Theme files are now loaded via request_firmware() > + sysfs hook to allow loading of theme files via request_firmware() > + Dropped the .enable cmdline option and the default file name. > The splash will be shown as soon as a file is specified. > + Dropped custom workqueue in favor of the kernel queue > and cancel_delayed_work_sync() > + Marked loaded data as const, and load/enable it atomically > + Reduced global state by moving data into other structures > + EXPORT_SYMBOL_GPL for fbcon_set_dummyops() > + Atomic and barrier for splash enabled state instead of spinlock > + Reduced warnings to infos > + Rate limited printk > + Changed the multi-line comment layout to kernel style > + Simplified the file headers > + reST-ed the documentation Ok, here's my expectation: - fix plymouth and driver loading If the plymouth maintainer tells me that's impossible, I'll look at this again. And no, this does not require killing drivers with SIGBUS, at least not with drm. Meanwhile I don't think this RFC makes sense to be merged. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch