From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752407AbdLULM6 (ORCPT ); Thu, 21 Dec 2017 06:12:58 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:33138 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbdLULMy (ORCPT ); Thu, 21 Dec 2017 06:12:54 -0500 X-Google-Smtp-Source: ACJfBouyyRaYeFITjrAMD2LBZeNsjyR+65ZPoXmqdjVE21l73wImabXDnG1yy8BSG3WwVmeIxgAT+A== From: Bartosz Golaszewski To: Mark Brown , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [RESEND PATCH] regmap: debugfs: emit a debug message when locking is disabled Date: Thu, 21 Dec 2017 12:12:50 +0100 Message-Id: <20171221111250.13423-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We currently silently omit creating the debugfs entries when regmap locking is disabled. Users may not be aware of the reason for which regmap files don't show up in debugfs. Add a dev_dbg() message explaining that. Signed-off-by: Bartosz Golaszewski --- As discussed in private: this patch seems to have been lost, so resending. drivers/base/regmap/regmap-debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c index c8ecefd75d6f..ae962b756863 100644 --- a/drivers/base/regmap/regmap-debugfs.c +++ b/drivers/base/regmap/regmap-debugfs.c @@ -529,8 +529,10 @@ void regmap_debugfs_init(struct regmap *map, const char *name) struct regmap_range_node *range_node; const char *devname = "dummy"; - if (map->debugfs_disable) + if (map->debugfs_disable) { + dev_dbg(map->dev, "regmap locking disabled - not creating debugfs entries\n"); return; + } /* If we don't have the debugfs root yet, postpone init */ if (!regmap_debugfs_root) { -- 2.15.1