From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
David Lechner <david@lechnology.com>,
Divagar Mohandass <divagar.mohandass@intel.com>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: [PATCH 1/5] dt-bindings: at24: consistently document the compatible property
Date: Thu, 21 Dec 2017 14:08:26 +0100 [thread overview]
Message-ID: <20171221130830.16813-2-brgl@bgdev.pl> (raw)
In-Reply-To: <20171221130830.16813-1-brgl@bgdev.pl>
Current description of the compatible property for at24 is quite vague.
Specify an exact list of accepted compatibles and document the - now
deprecated - strings which were previously used in device tree files.
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 50 +++++++++++++----------
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index cbc80e194ac6..6ccbd000bfa4 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -2,28 +2,34 @@ EEPROMs (I2C)
Required properties:
- - compatible : should be "<manufacturer>,<type>", like these:
-
- "atmel,24c00", "atmel,24c01", "atmel,24c02", "atmel,24c04",
- "atmel,24c08", "atmel,24c16", "atmel,24c32", "atmel,24c64",
- "atmel,24c128", "atmel,24c256", "atmel,24c512", "atmel,24c1024"
-
- "catalyst,24c32"
-
- "microchip,24c128"
-
- "ramtron,24c64"
-
- "renesas,r1ex24002"
-
- The following manufacturers values have been deprecated:
- "at", "at24"
-
- If there is no specific driver for <manufacturer>, a generic
- device with <type> and manufacturer "atmel" should be used.
- Possible types are:
- "24c00", "24c01", "24c02", "24c04", "24c08", "24c16", "24c32", "24c64",
- "24c128", "24c256", "24c512", "24c1024", "spd"
+ - compatible: must be one of the following:
+
+ "atmel,24c00",
+ "atmel,24c01",
+ "atmel,24c02",
+ "atmel,24c04",
+ "atmel,24c08",
+ "atmel,24c16",
+ "atmel,24c32",
+ "atmel,24c64",
+ "atmel,24c128",
+ "atmel,24c256",
+ "atmel,24c512",
+ "atmel,24c1024"
+
+ NOTE: old compatible strings, such as:
+
+ "catalyst,24c32",
+ "microchip,24c128",
+ "ramtron,24c64",
+ "renesas,r1ex24002",
+ "at,24c08",
+ "at24,24c08"
+
+ will still work, but are now deprecated.
+
+ Also: matching by device type alone - while still supported due to
+ implementation details in I2C core - is deprecated as well.
- reg : the I2C address of the EEPROM
--
2.15.1
next prev parent reply other threads:[~2017-12-21 13:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 13:08 [PATCH 0/5] eeprom: at24: device tree support fixes Bartosz Golaszewski
2017-12-21 13:08 ` Bartosz Golaszewski [this message]
[not found] ` <20171221130830.16813-2-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 13:19 ` [PATCH 1/5] dt-bindings: at24: consistently document the compatible property Javier Martinez Canillas
2017-12-21 13:19 ` Javier Martinez Canillas
[not found] ` <CABxcv==wt_brqA38P6OA846rW5K5Mjk3HxBpLfqXD-ZSpQ34YQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-21 13:28 ` Bartosz Golaszewski
2017-12-21 13:28 ` Bartosz Golaszewski
2017-12-21 13:29 ` Javier Martinez Canillas
[not found] ` <20171221130830.16813-1-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 13:08 ` [PATCH 2/5] dt-bindings: at24: add a missing compatible Bartosz Golaszewski
2017-12-21 13:08 ` Bartosz Golaszewski
2017-12-21 13:20 ` Javier Martinez Canillas
2017-12-21 13:08 ` [PATCH 3/5] dt-bindings: at24: fix formatting and style Bartosz Golaszewski
2017-12-21 13:21 ` Javier Martinez Canillas
2017-12-21 13:08 ` [PATCH 4/5] dt-bindings: at24: extend the list of supported chips Bartosz Golaszewski
2017-12-21 13:22 ` Javier Martinez Canillas
2017-12-21 13:08 ` [PATCH 5/5] eeprom: at24: extend the list of chips supported in DT Bartosz Golaszewski
2017-12-21 13:22 ` Javier Martinez Canillas
2017-12-21 13:50 ` [PATCH 0/5] eeprom: at24: device tree support fixes Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221130830.16813-2-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andy.shevchenko@gmail.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=divagar.mohandass@intel.com \
--cc=javier@dowhile0.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.