From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/3] drm/panel: Add Ilitek ILI9322 driver Date: Thu, 21 Dec 2017 15:15:56 +0100 Message-ID: <20171221141556.GB18544@ulmo> References: <20171201161659.9588-1-linus.walleij@linaro.org> <20171201161659.9588-2-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1647231433==" Return-path: Received: from mail-qt0-x242.google.com (mail-qt0-x242.google.com [IPv6:2607:f8b0:400d:c0d::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 374646E655 for ; Thu, 21 Dec 2017 14:16:00 +0000 (UTC) Received: by mail-qt0-x242.google.com with SMTP id a16so32558541qtj.3 for ; Thu, 21 Dec 2017 06:16:00 -0800 (PST) In-Reply-To: <20171201161659.9588-2-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: Ben Dooks , Stefano Babic , David Lechner , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1647231433== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 01, 2017 at 05:16:58PM +0100, Linus Walleij wrote: > This adds support for the Ilitek ILI9322 QVGA (320x240) > TFT panel driver. >=20 > This panel driver supports serial or parallel RGB or > YUV input and also ITU-T BT.656 input streams. >=20 > The controller is combined with a physical panel and > configured through the device tree. >=20 > Cc: David Lechner > Cc: Stefano Babic > Cc: Ben Dooks > Signed-off-by: Linus Walleij > --- > ChangeLog v1->v2: > - Dropped all DT parsing code in favor of open-coding the > display config on a per-system basis based on system-specific > compatible strings, after feedback from the DT maintainers. > - Define a set of configs for the D-Link DIR-685 router. > - Tested on the D-Link DIR-685. > --- > drivers/gpu/drm/panel/Kconfig | 8 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 962 +++++++++++++++++++++= ++++++ > 3 files changed, 971 insertions(+) > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9322.c checkpatch.pl gives me these: -:30: WARNING: please write a paragraph that describes the config symbol f= ully #30: FILE: drivers/gpu/drm/panel/Kconfig:31: +config DRM_PANEL_ILITEK_IL9322 -:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need upda= ting? #54: new file mode 100644 -:130: CHECK: Prefer using the BIT macro #130: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:72: +#define ILI9322_ENTRY_PAL (1 << 2) -:134: CHECK: Prefer using the BIT macro #134: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:76: +#define ILI9322_ENTRY_SERIAL_RGB_ALIGNED (1 << 4) -:196: CHECK: spaces preferred around that '|' (ctx:VxV) #196: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:138: +#define ILI9322_IF_CTRL_SYNC_DISABLED (BIT(2)|BIT(3)) ^ -:551: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/= timers/timers-howto.txt #551: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:493: + msleep(10); total: 0 errors, 3 warnings, 3 checks, 983 lines checked I'd like to see at least the warnings fixed. You can probably skip the entry in MAINTAINERS, though. I don't mind fixing these up while applying, but I don't know what to put in Kconfig. If you can send out a short paragraph for me to include I'll add it when I apply. Thierry --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlo7whwACgkQ3SOs138+ s6FMVw//fK07cqvNEus56A5tGASd7hOWiX9CggV6gNAVRryLZAPq4f2BHneGvcnq lQY+HFdfrz+crpnOcGjmgBjJntKSA6QQlfsBt9aKqcci92VrHHtvYf8pwmQ35KFk ooNB6bL/P3KsnVX6FDMaHS0dJhl1K68xoV3/XUtjaI6+2ljggu6v7HSLWyaePKsH ptSBQUsWKWaj+SimGcajMAe/HDrxm87xiUGtxv1XOOuXMMEfFBp/5sa6eqqu1kP5 UzQJSra2gZW/Z7cIFMtjwOgfIWF2stoJ9TaZu8wFE64r83RBq1sTyyu4xKZ5zXnY OGIeRg1DQGyI1xbOUbvdmQg8JBG4BqsNAKOhZJ/k1l3CQtrJrD4z0xuQR23r9Avk Kby/7HfUhggcOPx2EVMRCGCgZ1DYPh2HjzdJogQICtKhnip2z8ZeWmuqO9xu0vbk WIMaVyN9KP4coSqTnKvAMtTgxyufTAUB7jhZH7vGOekUDDFGm2ExqZulgueX6Scl 5ZSbKICm/wbIv/34HEV+4zXoyO5DHWtCn/TLOqo3YBWgtq7tNMEZrZ0pea8nz4iJ lIUvqulMWHaTQTWNtCk1SzCAOIzI+Z/n8eGH4Wn6QaUL8XeKBo7GU7xtNx0NNFGm t678v4/TNPdTS2BGMCcpr1twHu+cLDe0ry36puX5Pk75cdxz64s= =cPEp -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1-- --===============1647231433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1647231433==--