From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 2/3] drm/panel: Add Ilitek ILI9322 driver Date: Thu, 21 Dec 2017 17:15:52 +0100 Message-ID: <20171221161552.GA17476@ulmo> References: <20171201161659.9588-1-linus.walleij@linaro.org> <20171201161659.9588-2-linus.walleij@linaro.org> <20171221141556.GB18544@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0553055969==" Return-path: Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACC876E019 for ; Thu, 21 Dec 2017 16:15:55 +0000 (UTC) Received: by mail-qk0-x244.google.com with SMTP id x7so14113511qkb.0 for ; Thu, 21 Dec 2017 08:15:55 -0800 (PST) In-Reply-To: <20171221141556.GB18544@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: Ben Dooks , Stefano Babic , David Lechner , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0553055969== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7" Content-Disposition: inline --fdj2RfSjLxBAspz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 21, 2017 at 03:15:56PM +0100, Thierry Reding wrote: > On Fri, Dec 01, 2017 at 05:16:58PM +0100, Linus Walleij wrote: > > This adds support for the Ilitek ILI9322 QVGA (320x240) > > TFT panel driver. > >=20 > > This panel driver supports serial or parallel RGB or > > YUV input and also ITU-T BT.656 input streams. > >=20 > > The controller is combined with a physical panel and > > configured through the device tree. > >=20 > > Cc: David Lechner > > Cc: Stefano Babic > > Cc: Ben Dooks > > Signed-off-by: Linus Walleij > > --- > > ChangeLog v1->v2: > > - Dropped all DT parsing code in favor of open-coding the > > display config on a per-system basis based on system-specific > > compatible strings, after feedback from the DT maintainers. > > - Define a set of configs for the D-Link DIR-685 router. > > - Tested on the D-Link DIR-685. > > --- > > drivers/gpu/drm/panel/Kconfig | 8 + > > drivers/gpu/drm/panel/Makefile | 1 + > > drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 962 +++++++++++++++++++= ++++++++ > > 3 files changed, 971 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9322.c >=20 > checkpatch.pl gives me these: >=20 > -:30: WARNING: please write a paragraph that describes the config symbol= fully > #30: FILE: drivers/gpu/drm/panel/Kconfig:31: > +config DRM_PANEL_ILITEK_IL9322 >=20 > -:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need up= dating? > #54: > new file mode 100644 >=20 > -:130: CHECK: Prefer using the BIT macro > #130: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:72: > +#define ILI9322_ENTRY_PAL (1 << 2) >=20 > -:134: CHECK: Prefer using the BIT macro > #134: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:76: > +#define ILI9322_ENTRY_SERIAL_RGB_ALIGNED (1 << 4) >=20 > -:196: CHECK: spaces preferred around that '|' (ctx:VxV) > #196: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:138: > +#define ILI9322_IF_CTRL_SYNC_DISABLED (BIT(2)|BIT(3)) > ^ >=20 > -:551: WARNING: msleep < 20ms can sleep for up to 20ms; see Documentatio= n/timers/timers-howto.txt > #551: FILE: drivers/gpu/drm/panel/panel-ilitek-ili9322.c:493: > + msleep(10); >=20 > total: 0 errors, 3 warnings, 3 checks, 983 lines checked >=20 > I'd like to see at least the warnings fixed. You can probably skip the > entry in MAINTAINERS, though. I don't mind fixing these up while > applying, but I don't know what to put in Kconfig. If you can send out > a short paragraph for me to include I'll add it when I apply. Daniel just reminded me on IRC that you have commit rights to drm-misc, so once you've fixed up the bulk of the checkpatch warnings (nevermind those "prefer the BIT macro" checks), feel free to push this yourself with my: Acked-by: Thierry Reding --fdj2RfSjLxBAspz7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlo73jgACgkQ3SOs138+ s6E4oRAAgFn/9KV8bpO8px458FgnBnRGIIAq1OZx1WFK32HAWFbMWzqyB18CXKf1 /Va/C3xScZp8wNqvlldaSExm0YwWVIpFTxBBgoBfRmv+ciLvhpCrelhWx3Qxix2B U/YyslpI/Ff1bSTYTpw77tckdAbBsf9GvVcF1hp7DsugKo/h8Bp9wVXlW9egKQLR zEql4nNpWFIZ6jcIeUkbOuIpTFBVBMk+fK1EB1d6iMiCEZs4dy3yggmL85IVYdpo kX4JQ9mKQlJ/hd7LsqWz9zsafkKNK1GjnVd0np/Yp0C4XCs1dMYTMwWNAsoscELo 2PSUVCJBon4Fiemln9PGAarEjnsb+eNGpddjphh/9Mg/eH3tXzgX3Y15DK47X+RH ocyKMdLmPqOtPhuLLTLVkbZd5zP7Y6OSADMv4RscELAc8BJDxm7Fz4N8KHadA2g8 Gdt3ALD5YBqFA9lNhaucDCFXEf1bSQhfK3hhc73JSA8Qnt2zlHG4/PRA78FMNKKa s0aq2GOUKsziIB+hsBjllXJAaFnTJeNYTNcWh/wRHSZhVuELpWFYsQRMmk6YHaCB 0VLlHnsx0PlkW0qlE/ClIvLQBlvDz9utoe7EjGyDT2hTiXZvxTQWmcp7kiIgFs2S Zfd9DwRpI5S9MZcjOta0cKUxPSGKBIKlgW/apaPSqS69qMDXEw4= =uIhW -----END PGP SIGNATURE----- --fdj2RfSjLxBAspz7-- --===============0553055969== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0553055969==--