From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v1 1/2] s390x/tcg: implement TEST PROTECTION
Date: Thu, 21 Dec 2017 18:17:14 +0100 [thread overview]
Message-ID: <20171221181714.092a776f.cohuck@redhat.com> (raw)
In-Reply-To: <588a1a23-843c-c7e0-b174-8deb84b41b80@redhat.com>
On Tue, 19 Dec 2017 11:32:16 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 19.12.2017 09:20, Thomas Huth wrote:
> > On 18.12.2017 23:46, David Hildenbrand wrote:
> >> + /*
> >> + * TODO: we currently don't handle all access protection types
> >> + * (including access-list and key-controlled) as well as AR mode.
> >> + */
> >
> > Maybe add some "if (a2 & 0xf0) qemu_log_mask(LOG_UNIMPL, ...)" so that
> > we've got a chance to detect such conditions later?
> >
>
> In general I would agree, however as such acess-list + storage key stuff
> is missing literally all over the place, I don't think it is very helpful.
>
> Once (if ever) we implement it, we will have to go through the whole PoP
> either way and fixup all functions.
The TODO is fine with me.
Out of curiousity, do you already have an idea how much work that would
be? (Not asking for patches right now, mind you :)
next prev parent reply other threads:[~2017-12-21 17:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 22:46 [Qemu-devel] [PATCH v1 0/2] s390x/tcg: TEST PROTECTION and memory hotplug David Hildenbrand
2017-12-18 22:46 ` [Qemu-devel] [PATCH v1 1/2] s390x/tcg: implement TEST PROTECTION David Hildenbrand
2017-12-19 8:20 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-12-19 10:32 ` David Hildenbrand
2017-12-21 17:17 ` Cornelia Huck [this message]
2017-12-18 22:46 ` [Qemu-devel] [PATCH v1 2/2] s390x/sclp: fix missing be conversion David Hildenbrand
2017-12-19 8:25 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2017-12-22 10:57 ` [Qemu-devel] [PATCH v1 0/2] s390x/tcg: TEST PROTECTION and memory hotplug Cornelia Huck
2018-01-12 10:43 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-01-12 10:51 ` Cornelia Huck
2018-01-12 10:52 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171221181714.092a776f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.