Re: [PATCH 1/2] xfs: quota: fix missed destroy of qi_tree_lock

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Thu, Dec 21, 2017 at 11:17:42PM +0300, Aliaksei Karaliou wrote:
> xfs_qm_destroy_quotainfo() does not destroy quotainfo->qi_tree_lock
> while destroys quotainfo->qi_quotaofflock.
> 
> Signed-off-by: Aliaksei Karaliou <akaraliou.dev@gmail.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  fs/xfs/xfs_qm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index ec952dfad359..d0053115427f 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -736,6 +736,7 @@ xfs_qm_destroy_quotainfo(
>  		IRELE(qi->qi_pquotaip);
>  		qi->qi_pquotaip = NULL;
>  	}
> +	mutex_destroy(&qi->qi_tree_lock);
>  	mutex_destroy(&qi->qi_quotaofflock);
>  	kmem_free(qi);
>  	mp->m_quotainfo = NULL;
> -- 
> 2.11.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html