Re: [PATCH] Fix const confusion in intel-mid x86 platform drivers

[Darren Hart <dvhart@infradead.org>]

On Thu, Dec 21, 2017 at 04:14:43PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> const must be marked __initconst, not __initdata
> 

Thanks Andi,

This file should go through the x86 maintainers per the current MAINTAINERS
file. So to avoid risk of duplication, added Thomas et al. to Cc.

Thomas, we discussed moving more of arch/x86/platform to drivers/platform/x86.
We have migrated pmc_atom already, but a lot remains. Do you want to pull
patches like this in the interim, or should we move arch/x86/platform under
our entry in MAINTAINERS now?

Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>


> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  arch/x86/platform/intel-mid/device_libs/platform_bt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/platform/intel-mid/device_libs/platform_bt.c b/arch/x86/platform/intel-mid/device_libs/platform_bt.c
> index dc036e511f48..2b5d86ce24c2 100644
> --- a/arch/x86/platform/intel-mid/device_libs/platform_bt.c
> +++ b/arch/x86/platform/intel-mid/device_libs/platform_bt.c
> @@ -60,7 +60,7 @@ static int __init tng_bt_sfi_setup(struct bt_sfi_data *ddata)
>  	return 0;
>  }
>  
> -static const struct bt_sfi_data tng_bt_sfi_data __initdata = {
> +static const struct bt_sfi_data tng_bt_sfi_data __initconst = {
>  	.setup	= tng_bt_sfi_setup,
>  };
>  
> -- 
> 2.15.0
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center