Re: [PATCH v2 1/1] Move kfree_call_rcu() to slab_common.c

[Boqun Feng <boqun.feng@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

On Fri, Dec 22, 2017 at 10:38:46AM +0800, Boqun Feng wrote:
> On Thu, Dec 21, 2017 at 05:42:12PM -0800, Paul E. McKenney wrote:
> > On Fri, Dec 22, 2017 at 09:17:04AM +0800, Boqun Feng wrote:
> > > Hi Shoaib,
> > > 
> > > On Thu, Dec 21, 2017 at 02:32:50PM -0800, rao.shoaib@oracle.com wrote:
> > > > From: Rao Shoaib <rao.shoaib@oracle.com>
> > > > 
> > > > This patch moves kfree_call_rcu() and related macros out of rcu code.
> > > > A new function call_rcu_lazy() is created for calling __call_rcu() with
> > > > the lazy flag. kfree_call_rcu() in the tiny implementation remains unchanged.
> > > > 
> > > 
> > > Mind to explain why you want to do this in the commit log?
> > 
> > I am too close to this one, so I need you guys to hash this out.  ;-)
> > 
> 
> I think simply improving the modularity is OK, but it's better to have
> some words in the commit log ;-)
> 

Hmm.. seems like this is first part of the split version for:

	https://lkml.kernel.org/r/1513705948-31072-1-git-send-email-rao.shoaib@oracle.com

In that case, Shoaib, I think you'd better send the whole thing as a
proper patchset(which is a set of patches) and write a cover letter.

Feel free to ask questions ;-)

Regards,
Boqun

[...]

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]