From: Jiri Pirko <jiri@resnulli.us>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap()
Date: Fri, 22 Dec 2017 10:38:06 +0100 [thread overview]
Message-ID: <20171222093806.GB11519@nanopsycho> (raw)
In-Reply-To: <CAM_iQpVyycftiydUi3VJsZ1QMj45dWDvkmsOquT10JqF-zrwkw@mail.gmail.com>
Thu, Dec 21, 2017 at 09:54:06PM CET, xiyou.wangcong@gmail.com wrote:
>On Thu, Dec 21, 2017 at 11:01 AM, Cong Wang <xiyou.wangcong@gmail.com> wrote:
>> On Thu, Dec 21, 2017 at 1:03 AM, Jiri Pirko <jiri@resnulli.us> wrote:
>>>
>>>
>>> But again, we don't we just free qdisc in call_rcu and avoid the
>>> barrier?
>>
>>
>> Non-sense again. Why qdisc code should be adjusted for your
>> miniq code? It is your own responsibility to take care of this shit.
>> Don't spread it out of minq.
>
>Also, in case you believe call_rcu to free qdisc is queued after
>the call_rcu in miniq, you are wrong again:
I certainly don't :) Not sure why you think I do.
>
>https://www.kernel.org/pub/linux/kernel/people/paulmck/Answers/RCU/RCUCBordering.html
>
>The rcu callbacks don't guarantee FIFO ordering.
next prev parent reply other threads:[~2017-12-22 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-21 7:26 [Patch net] net_sched: fix a missing rcu barrier in mini_qdisc_pair_swap() Cong Wang
2017-12-21 9:03 ` Jiri Pirko
2017-12-21 19:01 ` Cong Wang
2017-12-21 20:54 ` Cong Wang
2017-12-22 9:38 ` Jiri Pirko [this message]
2017-12-22 10:23 ` Jiri Pirko
2017-12-22 10:24 ` Jiri Pirko
2017-12-26 17:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171222093806.GB11519@nanopsycho \
--to=jiri@resnulli.us \
--cc=jiri@mellanox.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.