All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Test creating overlay when guest running
Date: Fri, 22 Dec 2017 13:47:32 +0100	[thread overview]
Message-ID: <20171222124732.GC3763@localhost.localdomain> (raw)
In-Reply-To: <20171215080446.10671-3-famz@redhat.com>

Am 15.12.2017 um 09:04 hat Fam Zheng geschrieben:
> Signed-off-by: Fam Zheng <famz@redhat.com>

The updated test case passes even without your fix. I can reproduce the
problem manually and verify that patch 1 fixes it, but the test case
seems ineffective.

And having a closer look at the test, this is because the running VM
opened its images read-only.

Kevin

  parent reply	other threads:[~2017-12-22 12:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15  8:04 [Qemu-devel] [PATCH 0/2] block: Fix qemu-img creating overlay when guest running Fam Zheng
2017-12-15  8:04 ` [Qemu-devel] [PATCH 1/2] block: Open backing image in force share mode for size probe Fam Zheng
2017-12-22 12:49   ` Kevin Wolf
2017-12-15  8:04 ` [Qemu-devel] [PATCH 2/2] iotests: Test creating overlay when guest running Fam Zheng
2017-12-15 19:49   ` Eric Blake
2017-12-22 12:47   ` Kevin Wolf [this message]
2017-12-15 19:51 ` [Qemu-devel] [PATCH 0/2] block: Fix qemu-img " Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171222124732.GC3763@localhost.localdomain \
    --to=kwolf@redhat.com \
    --cc=famz@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.