From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache Date: Sat, 23 Dec 2017 14:45:32 +0100 Message-ID: <20171223134532.GA10103@kroah.com> References: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Yisheng Xie Cc: linux-mips@linux-mips.org, ulf.hansson@linaro.org, jakub.kicinski@netronome.com, lgirdwood@gmail.com, airlied@linux.ie, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, daniel.vetter@intel.com, tglx@linutronix.de, linux-watchdog@vger.kernel.org, linux-rtc@vger.kernel.org, boris.brezillon@free-electrons.com, andriy.shevchenko@linux.intel.com, vinod.koul@intel.com, richard@nod.at, alexandre.belloni@free-electrons.com, marek.vasut@gmail.com, industrypack-devel@lists.sourceforge.net, jslaby@suse.com, dvhart@infradead.org, linux@roeck-us.net, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, jason@lakedaemon.net, arnd@arndb.de, b.zolnierkie@samsung.com, marc.zyngier@arm.com, linux-mmc@vger.kernel.org, linux-can@vger.kernel.org, linux-gp List-Id: alsa-devel@alsa-project.org T24gU2F0LCBEZWMgMjMsIDIwMTcgYXQgMDc6MDI6NTlQTSArMDgwMCwgWWlzaGVuZyBYaWUgd3Jv dGU6Cj4gLS0tIGEvbGliL2RldnJlcy5jCj4gKysrIGIvbGliL2RldnJlcy5jCj4gQEAgLTQ0LDM1 ICs0NCw2IEBAIHZvaWQgX19pb21lbSAqZGV2bV9pb3JlbWFwKHN0cnVjdCBkZXZpY2UgKmRldiwg cmVzb3VyY2Vfc2l6ZV90IG9mZnNldCwKPiAgRVhQT1JUX1NZTUJPTChkZXZtX2lvcmVtYXApOwo+ ICAKPiAgLyoqCj4gLSAqIGRldm1faW9yZW1hcF9ub2NhY2hlIC0gTWFuYWdlZCBpb3JlbWFwX25v Y2FjaGUoKQo+IC0gKiBAZGV2OiBHZW5lcmljIGRldmljZSB0byByZW1hcCBJTyBhZGRyZXNzIGZv cgo+IC0gKiBAb2Zmc2V0OiBSZXNvdXJjZSBhZGRyZXNzIHRvIG1hcAo+IC0gKiBAc2l6ZTogU2l6 ZSBvZiBtYXAKPiAtICoKPiAtICogTWFuYWdlZCBpb3JlbWFwX25vY2FjaGUoKS4gIE1hcCBpcyBh dXRvbWF0aWNhbGx5IHVubWFwcGVkIG9uIGRyaXZlcgo+IC0gKiBkZXRhY2guCj4gLSAqLwo+IC12 b2lkIF9faW9tZW0gKmRldm1faW9yZW1hcF9ub2NhY2hlKHN0cnVjdCBkZXZpY2UgKmRldiwgcmVz b3VyY2Vfc2l6ZV90IG9mZnNldCwKPiAtCQkJCSAgIHJlc291cmNlX3NpemVfdCBzaXplKQo+IC17 Cj4gLQl2b2lkIF9faW9tZW0gKipwdHIsICphZGRyOwo+IC0KPiAtCXB0ciA9IGRldnJlc19hbGxv YyhkZXZtX2lvcmVtYXBfcmVsZWFzZSwgc2l6ZW9mKCpwdHIpLCBHRlBfS0VSTkVMKTsKPiAtCWlm ICghcHRyKQo+IC0JCXJldHVybiBOVUxMOwo+IC0KPiAtCWFkZHIgPSBpb3JlbWFwX25vY2FjaGUo b2Zmc2V0LCBzaXplKTsKCldhaXQsIGRldm1faW9yZW1hcCgpIGNhbGxzIGlvcmVtYXAoKSwgbm90 IGlvcmVtYXBfbm9jYWNoZSgpLCBhcmUgeW91Cl9TVVJFXyB0aGF0IHRoZXNlIGFyZSBhbGwgaWRl bnRpY2FsPyAgRm9yIGFsbCBhcmNoZXM/ICBJZiBzbywgdGhlbgppb3JlbWFwX25vY2FjaGUoKSBj YW4gYWxzbyBiZSByZW1vdmVkLCByaWdodD8KCkluIG15IHF1aWNrIGdsYW5jZSwgSSBkb24ndCB0 aGluayB5b3UgY2FuIGRvIHRoaXMgc2VyaWVzIGF0IGFsbCA6KAoKZ3JlZyBrLWgKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,27/27] devres: kill devm_ioremap_nocache From: Greg Kroah-Hartman Message-Id: <20171223134532.GA10103@kroah.com> Date: Sat, 23 Dec 2017 14:45:32 +0100 To: Yisheng Xie Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, ulf.hansson@linaro.org, jakub.kicinski@netronome.com, airlied@linux.ie, linux-wireless@vger.kernel.org, linus.walleij@linaro.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, daniel.vetter@intel.com, dan.j.williams@intel.com, jason@lakedaemon.net, linux-rtc@vger.kernel.org, boris.brezillon@free-electrons.com, mchehab@kernel.org, dmaengine@vger.kernel.org, vinod.koul@intel.com, richard@nod.at, marek.vasut@gmail.com, industrypack-devel@lists.sourceforge.net, linux-pci@vger.kernel.org, dvhart@infradead.org, linux@roeck-us.net, linux-media@vger.kernel.org, seanpaul@chromium.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, marc.zyngier@arm.com, jslaby@suse.com, jani.nikula@linux.intel.com, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, mkl@pengutronix.de, linux-fbdev@vger.kernel.org, nios2-dev@lists.rocketboards.org, bhelgaas@google.com, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, kvalo@codeaurora.org, a.zummo@towertech.it, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, lgirdwood@gmail.com, ralf@linux-mips.org, linux-spi@vger.kernel.org, ysxie@foxmail.com, wg@grandegger.com, cyrille.pitchen@wedev4u.fr, tj@kernel.org, alexandre.belloni@free-electrons.com, davem@davemloft.net, andy@infradead.org List-ID: T24gU2F0LCBEZWMgMjMsIDIwMTcgYXQgMDc6MDI6NTlQTSArMDgwMCwgWWlzaGVuZyBYaWUgd3Jv dGU6Cj4gLS0tIGEvbGliL2RldnJlcy5jCj4gKysrIGIvbGliL2RldnJlcy5jCj4gQEAgLTQ0LDM1 ICs0NCw2IEBAIHZvaWQgX19pb21lbSAqZGV2bV9pb3JlbWFwKHN0cnVjdCBkZXZpY2UgKmRldiwg cmVzb3VyY2Vfc2l6ZV90IG9mZnNldCwKPiAgRVhQT1JUX1NZTUJPTChkZXZtX2lvcmVtYXApOwo+ ICAKPiAgLyoqCj4gLSAqIGRldm1faW9yZW1hcF9ub2NhY2hlIC0gTWFuYWdlZCBpb3JlbWFwX25v Y2FjaGUoKQo+IC0gKiBAZGV2OiBHZW5lcmljIGRldmljZSB0byByZW1hcCBJTyBhZGRyZXNzIGZv cgo+IC0gKiBAb2Zmc2V0OiBSZXNvdXJjZSBhZGRyZXNzIHRvIG1hcAo+IC0gKiBAc2l6ZTogU2l6 ZSBvZiBtYXAKPiAtICoKPiAtICogTWFuYWdlZCBpb3JlbWFwX25vY2FjaGUoKS4gIE1hcCBpcyBh dXRvbWF0aWNhbGx5IHVubWFwcGVkIG9uIGRyaXZlcgo+IC0gKiBkZXRhY2guCj4gLSAqLwo+IC12 b2lkIF9faW9tZW0gKmRldm1faW9yZW1hcF9ub2NhY2hlKHN0cnVjdCBkZXZpY2UgKmRldiwgcmVz b3VyY2Vfc2l6ZV90IG9mZnNldCwKPiAtCQkJCSAgIHJlc291cmNlX3NpemVfdCBzaXplKQo+IC17 Cj4gLQl2b2lkIF9faW9tZW0gKipwdHIsICphZGRyOwo+IC0KPiAtCXB0ciA9IGRldnJlc19hbGxv YyhkZXZtX2lvcmVtYXBfcmVsZWFzZSwgc2l6ZW9mKCpwdHIpLCBHRlBfS0VSTkVMKTsKPiAtCWlm ICghcHRyKQo+IC0JCXJldHVybiBOVUxMOwo+IC0KPiAtCWFkZHIgPSBpb3JlbWFwX25vY2FjaGUo b2Zmc2V0LCBzaXplKTsKCldhaXQsIGRldm1faW9yZW1hcCgpIGNhbGxzIGlvcmVtYXAoKSwgbm90 IGlvcmVtYXBfbm9jYWNoZSgpLCBhcmUgeW91Cl9TVVJFXyB0aGF0IHRoZXNlIGFyZSBhbGwgaWRl bnRpY2FsPyAgRm9yIGFsbCBhcmNoZXM/ICBJZiBzbywgdGhlbgppb3JlbWFwX25vY2FjaGUoKSBj YW4gYWxzbyBiZSByZW1vdmVkLCByaWdodD8KCkluIG15IHF1aWNrIGdsYW5jZSwgSSBkb24ndCB0 aGluayB5b3UgY2FuIGRvIHRoaXMgc2VyaWVzIGF0IGFsbCA6KAoKZ3JlZyBrLWgKLS0tClRvIHVu c3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBkbWFl bmdpbmUiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJuZWwu b3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jk b21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Sat, 23 Dec 2017 13:45:32 +0000 Subject: Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache Message-Id: <20171223134532.GA10103@kroah.com> List-Id: References: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> In-Reply-To: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yisheng Xie Cc: linux-mips@linux-mips.org, ulf.hansson@linaro.org, jakub.kicinski@netronome.com, lgirdwood@gmail.com, airlied@linux.ie, linux-pci@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, daniel.vetter@intel.com, tglx@linutronix.de, linux-watchdog@vger.kernel.org, linux-rtc@vger.kernel.org, boris.brezillon@free-electrons.com, andriy.shevchenko@linux.intel.com, vinod.koul@intel.com, richard@nod.at, alexandre.belloni@free-electrons.com, marek.vasut@gmail.com, industrypack-devel@lists.sourceforge.net, jslaby@suse.com, dvhart@infradead.org, linux@roeck-us.net, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, jason@lakedaemon.net, arnd@arndb.de, b.zolnierkie@samsung.com, marc.zyngier@arm.com, linux-mmc@vger.kernel.org, linux-can@vger.kernel.org, linux-gp On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: > --- a/lib/devres.c > +++ b/lib/devres.c > @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset, > EXPORT_SYMBOL(devm_ioremap); > > /** > - * devm_ioremap_nocache - Managed ioremap_nocache() > - * @dev: Generic device to remap IO address for > - * @offset: Resource address to map > - * @size: Size of map > - * > - * Managed ioremap_nocache(). Map is automatically unmapped on driver > - * detach. > - */ > -void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset, > - resource_size_t size) > -{ > - void __iomem **ptr, *addr; > - > - ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL); > - if (!ptr) > - return NULL; > - > - addr = ioremap_nocache(offset, size); Wait, devm_ioremap() calls ioremap(), not ioremap_nocache(), are you _SURE_ that these are all identical? For all arches? If so, then ioremap_nocache() can also be removed, right? In my quick glance, I don't think you can do this series at all :( greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 23 Dec 2017 14:45:46 +0100 (CET) Received: from mail.linuxfoundation.org ([140.211.169.12]:34590 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23990395AbdLWNpjll3PY (ORCPT ); Sat, 23 Dec 2017 14:45:39 +0100 Received: from localhost (LFbn-1-12262-44.w90-92.abo.wanadoo.fr [90.92.75.44]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 2FAA5927; Sat, 23 Dec 2017 13:45:31 +0000 (UTC) Date: Sat, 23 Dec 2017 14:45:32 +0100 From: Greg KH To: Yisheng Xie Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, ulf.hansson@linaro.org, jakub.kicinski@netronome.com, airlied@linux.ie, linux-wireless@vger.kernel.org, linus.walleij@linaro.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, daniel.vetter@intel.com, dan.j.williams@intel.com, jason@lakedaemon.net, linux-rtc@vger.kernel.org, boris.brezillon@free-electrons.com, mchehab@kernel.org, dmaengine@vger.kernel.org, vinod.koul@intel.com, richard@nod.at, marek.vasut@gmail.com, industrypack-devel@lists.sourceforge.net, linux-pci@vger.kernel.org, dvhart@infradead.org, linux@roeck-us.net, linux-media@vger.kernel.org, seanpaul@chromium.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, arnd@arndb.de, b.zolnierkie@samsung.com, marc.zyngier@arm.com, jslaby@suse.com, jani.nikula@linux.intel.com, linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, mkl@pengutronix.de, linux-fbdev@vger.kernel.org, nios2-dev@lists.rocketboards.org, bhelgaas@google.com, tglx@linutronix.de, andriy.shevchenko@linux.intel.com, kvalo@codeaurora.org, a.zummo@towertech.it, netdev@vger.kernel.org, linux-mmc@vger.kernel.org, lgirdwood@gmail.com, ralf@linux-mips.org, linux-spi@vger.kernel.org, ysxie@foxmail.com, wg@grandegger.com, cyrille.pitchen@wedev4u.fr, tj@kernel.org, alexandre.belloni@free-electrons.com, davem@davemloft.net, andy@infradead.org Subject: Re: [PATCH v3 27/27] devres: kill devm_ioremap_nocache Message-ID: <20171223134532.GA10103@kroah.com> References: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1514026979-33838-1-git-send-email-xieyisheng1@huawei.com> User-Agent: Mutt/1.9.2 (2017-12-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 61561 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: gregkh@linuxfoundation.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Sat, Dec 23, 2017 at 07:02:59PM +0800, Yisheng Xie wrote: > --- a/lib/devres.c > +++ b/lib/devres.c > @@ -44,35 +44,6 @@ void __iomem *devm_ioremap(struct device *dev, resource_size_t offset, > EXPORT_SYMBOL(devm_ioremap); > > /** > - * devm_ioremap_nocache - Managed ioremap_nocache() > - * @dev: Generic device to remap IO address for > - * @offset: Resource address to map > - * @size: Size of map > - * > - * Managed ioremap_nocache(). Map is automatically unmapped on driver > - * detach. > - */ > -void __iomem *devm_ioremap_nocache(struct device *dev, resource_size_t offset, > - resource_size_t size) > -{ > - void __iomem **ptr, *addr; > - > - ptr = devres_alloc(devm_ioremap_release, sizeof(*ptr), GFP_KERNEL); > - if (!ptr) > - return NULL; > - > - addr = ioremap_nocache(offset, size); Wait, devm_ioremap() calls ioremap(), not ioremap_nocache(), are you _SURE_ that these are all identical? For all arches? If so, then ioremap_nocache() can also be removed, right? In my quick glance, I don't think you can do this series at all :( greg k-h