From: Jiri Olsa <jolsa@redhat.com>
To: Aaron Tomlin <atomlin@redhat.com>
Cc: acme@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key
Date: Mon, 25 Dec 2017 22:46:46 +0100 [thread overview]
Message-ID: <20171225214646.GC25478@krava> (raw)
In-Reply-To: <20171224182315.xhz5n2z6dkibthzc@atomlin.usersys.com>
On Sun, Dec 24, 2017 at 06:23:15PM +0000, Aaron Tomlin wrote:
> On Sat 2017-12-23 00:59 +0100, Jiri Olsa wrote:
> [ ... ]
> > not sure we've already discussed that, but this could be default?
>
> Probably it is best to keep the default behaviour.
>
> I'd prefer a hexadecimal address offset, as the default, however perhaps
> someone is happy with the current default (decimal).
Arnaldo?
>
> > if not, I think the hex option should be part of -g option arg, maybe like:
>
> Does it have to be?
>
> > -g graph,callee,xaddress
>
> Not sure - adding another sort_key seems odd to me.
it's not sort key, it's -g option key.. but if we go for default
there's no need.. let's see ;-)
>
> But if you insist, perhaps address[=hex] would be cleaner?
but yes, that looks better to me
jirka
next prev parent reply other threads:[~2017-12-25 21:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 15:35 [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key Aaron Tomlin
2017-12-22 23:59 ` Jiri Olsa
2017-12-24 18:23 ` Aaron Tomlin
2017-12-25 21:46 ` Jiri Olsa [this message]
2017-12-26 14:51 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171225214646.GC25478@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=atomlin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.