Re: [PATCH 2/3] perf/core: Move inline keyword at the beginning of declaration

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Dec 26, 2017 at 03:09:13PM +0100, Mathieu Malaterre escreveu:
> Fix non-fatal warning:
> 
> kernel/events/core.c:6106:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static void __always_inline
>  ^~~~~~

Can you please provide more context? When did this become a problem?
What gcc version?

- Arnaldo
 
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 4df5b695bf0d..aa874d2b58b3 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6103,7 +6103,7 @@ void perf_prepare_sample(struct perf_event_header *header,
>  		data->phys_addr = perf_virt_to_phys(data->addr);
>  }
>  
> -static void __always_inline
> +static __always_inline void
>  __perf_event_output(struct perf_event *event,
>  		    struct perf_sample_data *data,
>  		    struct pt_regs *regs,
> -- 
> 2.11.0