From: Stephen Boyd <sboyd@codeaurora.org>
To: sean.wang@mediatek.com
Cc: mturquette@baylibre.com, matthias.bgg@gmail.com,
jdelvare@suse.de, jamesjj.liao@mediatek.com,
weiyi.lu@mediatek.com, arnd@arndb.de,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: mediatek: remove unnecessary include header from reset.c
Date: Tue, 26 Dec 2017 17:10:21 -0800 [thread overview]
Message-ID: <20171227011021.GQ7997@codeaurora.org> (raw)
In-Reply-To: <b5937ad5c068eeec19005d40dbddb97e09c1b3d0.1514190227.git.sean.wang@mediatek.com>
On 12/25, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
>
> In fact, the clk-mtk.h header is indeed not needed for reset.c and thus
> it's safe and good change to remove it from the file.
>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jean Delvare <jdelvare@suse.de>
> ---
> drivers/clk/mediatek/reset.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/mediatek/reset.c b/drivers/clk/mediatek/reset.c
> index d3551d5..70ebb2e 100644
> --- a/drivers/clk/mediatek/reset.c
> +++ b/drivers/clk/mediatek/reset.c
> @@ -19,8 +19,6 @@
> #include <linux/reset-controller.h>
> #include <linux/slab.h>
>
> -#include "clk-mtk.h"
> -
drivers/clk/mediatek/reset.c:64:6: warning: symbol 'mtk_register_reset_controller' was not declared. Should it be static?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-12-27 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 8:31 [PATCH] clk: mediatek: remove unnecessary include header from reset.c sean.wang
2017-12-25 8:31 ` sean.wang
2017-12-27 1:10 ` Stephen Boyd [this message]
2017-12-27 3:33 ` Sean Wang
2017-12-27 3:33 ` Sean Wang
2017-12-27 12:15 ` Jean Delvare
2017-12-27 12:15 ` Jean Delvare
2017-12-27 17:38 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227011021.GQ7997@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=arnd@arndb.de \
--cc=jamesjj.liao@mediatek.com \
--cc=jdelvare@suse.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=sean.wang@mediatek.com \
--cc=weiyi.lu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.