All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH v2 2/4] lapi/socket.h: Move definitions from netstress.c
Date: Wed, 27 Dec 2017 09:42:13 +0100	[thread overview]
Message-ID: <20171227084211.GA17258@x230> (raw)
In-Reply-To: <8186d043-06db-94a3-1da3-c2e57e42597b@oracle.com>

Hi Alexey,

thanks for your review.

> >  #ifndef SOCK_CLOEXEC
> >  # define SOCK_CLOEXEC 02000000
> >  #endif

> > +#ifndef SOCK_DCCP
> > +# define SOCK_DCCP		6
> > +#endif

> I would move it above SOCK_CLOEXEC, so we can keep the order
> of these flags similarly to bits/socket.h.
You probably mean bits/socket_type.h. Sure.

> The other patches in this set look good, thanks!
Just one exception, if you don't mind:
I use lapi/netinet_in.h instead of lapi/in.h. I don't like inconsistency (other headers in
lapi don't use prefix), but using just in.h is confusing, as there is also linux/in.h, as
Cyril pointed out.


Kind regards,
Petr

  reply	other threads:[~2017-12-27  8:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 19:27 [LTP] [RFC PATCH v2 0/4] Add headers in lapi Petr Vorel
2017-12-21 19:27 ` [LTP] [RFC PATCH v2 1/4] lapi: Add lapi/tcp.h with definitions moved from netstress.c Petr Vorel
2017-12-21 19:27 ` [LTP] [RFC PATCH v2 2/4] lapi/socket.h: Move definitions " Petr Vorel
2017-12-25  9:50   ` Alexey Kodanev
2017-12-27  8:42     ` Petr Vorel [this message]
2018-01-04  8:19       ` Petr Vorel
2017-12-21 19:27 ` [LTP] [RFC PATCH v2 3/4] lapi: Add lapi/in.h with definition moved " Petr Vorel
2017-12-21 19:27 ` [LTP] [RFC PATCH v2 4/4] lapi: Add lapi/dccp.h " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171227084211.GA17258@x230 \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.