From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [RFC] Can someone please review my latest wiki update
Date: Wed, 27 Dec 2017 21:38:13 +1100 [thread overview]
Message-ID: <20171227103813.GD3299@dimstar.local.net> (raw)
In-Reply-To: <20171218094816.ejlo4swg67ywyomy@salvia>
Hi Pablo,
On Mon, Dec 18, 2017 at 10:48:16AM +0100, Pablo Neira Ayuso wrote:
> Hi Duncan,
>
> On Sat, Dec 16, 2017 at 08:22:10PM +1100, Duncan Roe wrote:
> > Hi,
> >
> > For those who contribute to the wiki:
> >
> > I updated
> > https://wiki.nftables.org/wiki-nftables/index.php/Flow_tables section
> > "Doing iptables hashlimit with nft" in light of trying the examples.
> >
> > There's more in the associated discussion page,
>
> "Notice also that the translator defaults --hashlimit-htable-expire and
> --hashlimit-burst to 1000 milliseconds and 5 packets respectively so
> ''timeout 1s'' and ''burst 5 packets'' are inserted. You may remove
> either or both of these if you wish."
>
> I think we can just skip printing default values in the translation, I
> mean, we can "fix" the translation instead.
>
> BTW, this reminds me we should also expose the missing options such as
> hashlimit-htable-max and hashlimit-htable-gcinterval, those can be
> exposed too, it just needs some code in nft, I'll add this to my TODO
> list.
>
> Let us know, thanks for reviewing documentation!
Since there's a patch in the works to fix these spurious defaults, would you
mind if I just left it until the fix is committed?
Cheers ... Duncan.
next prev parent reply other threads:[~2017-12-27 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 9:22 [RFC] Can someone please review my latest wiki update Duncan Roe
2017-12-18 9:48 ` Pablo Neira Ayuso
2017-12-27 10:38 ` Duncan Roe [this message]
2017-12-27 13:08 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227103813.GD3299@dimstar.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.