From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 27 Dec 2017 13:52:04 +0100 From: Greg Kroah-Hartman To: Marcel Holtmann Cc: Kai-Heng Feng , linux-usb@vger.kernel.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , stable , Leif Liddy , Matthias Kaehlcke , Brian Norris , Daniel Drake Subject: Re: [PATCH 2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth Message-ID: <20171227125204.GE3373@kroah.com> References: <20171220110008.11856-1-kai.heng.feng@canonical.com> <20171220110008.11856-2-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: On Tue, Dec 26, 2017 at 10:01:46PM +0100, Marcel Holtmann wrote: > Hi Greg, > > > Commit ("fd865802c66bc451dc515ed89360f84376ce1a56 Bluetooth: btusb: fix > > QCA Rome suspend/resume") enables reset_resume in btusb_probe(). This > > makes the device resets during btusb_open(), firmware loading gets > > interrupted as a result. > > > > We still want to reset the device to solve the original issue, but we > > should do it before btusb_open(). > > > > Hence, add reset-resume quirk in usb core intead of btusb. > > > > Cc: stable@vger.kernel.org > > Cc: Leif Liddy > > Cc: Matthias Kaehlcke > > Cc: Brian Norris > > Cc: Daniel Drake > > Signed-off-by: Kai-Heng Feng > > > > --- > > drivers/usb/core/quirks.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > > index a10b346b9777..96951104c45b 100644 > > --- a/drivers/usb/core/quirks.c > > +++ b/drivers/usb/core/quirks.c > > @@ -197,6 +197,9 @@ static const struct usb_device_id usb_quirk_list[] = { > > { USB_DEVICE(0x0b05, 0x17e0), .driver_info = > > USB_QUIRK_IGNORE_REMOTE_WAKEUP }, > > > > + /* QCA Rome Bluetooth in Dell DW1820 wireless module */ > > + { USB_DEVICE(0x0cf3, 0xe007), .driver_info = USB_QUIRK_RESET_RESUME }, > > + > > can I get an ACK from you to take this patch through bluetooth-next tree? Or are you planning to take it? It's not in my queue at all, so I didn't even have the chance to take it :) Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] usb: quirks: Add reset-resume quirk for Dell DW1820 QCA Rome Bluetooth From: Greg Kroah-Hartman Message-Id: <20171227125204.GE3373@kroah.com> Date: Wed, 27 Dec 2017 13:52:04 +0100 To: Marcel Holtmann Cc: Kai-Heng Feng , linux-usb@vger.kernel.org, "open list:BLUETOOTH DRIVERS" , Linux Kernel Mailing List , stable , Leif Liddy , Matthias Kaehlcke , Brian Norris , Daniel Drake List-ID: T24gVHVlLCBEZWMgMjYsIDIwMTcgYXQgMTA6MDE6NDZQTSArMDEwMCwgTWFyY2VsIEhvbHRtYW5u IHdyb3RlOgo+IEhpIEdyZWcsCj4gCj4gPiBDb21taXQgKCJmZDg2NTgwMmM2NmJjNDUxZGM1MTVl ZDg5MzYwZjg0Mzc2Y2UxYTU2IEJsdWV0b290aDogYnR1c2I6IGZpeAo+ID4gUUNBIFJvbWUgc3Vz cGVuZC9yZXN1bWUiKSBlbmFibGVzIHJlc2V0X3Jlc3VtZSBpbiBidHVzYl9wcm9iZSgpLiBUaGlz Cj4gPiBtYWtlcyB0aGUgZGV2aWNlIHJlc2V0cyBkdXJpbmcgYnR1c2Jfb3BlbigpLCBmaXJtd2Fy ZSBsb2FkaW5nIGdldHMKPiA+IGludGVycnVwdGVkIGFzIGEgcmVzdWx0Lgo+ID4gCj4gPiBXZSBz dGlsbCB3YW50IHRvIHJlc2V0IHRoZSBkZXZpY2UgdG8gc29sdmUgdGhlIG9yaWdpbmFsIGlzc3Vl LCBidXQgd2UKPiA+IHNob3VsZCBkbyBpdCBiZWZvcmUgYnR1c2Jfb3BlbigpLgo+ID4gCj4gPiBI ZW5jZSwgYWRkIHJlc2V0LXJlc3VtZSBxdWlyayBpbiB1c2IgY29yZSBpbnRlYWQgb2YgYnR1c2Iu Cj4gPiAKPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiBDYzogTGVpZiBMaWRkeSA8 bGVpZi5saW51eEBnbWFpbC5jb20+Cj4gPiBDYzogTWF0dGhpYXMgS2FlaGxja2UgPG1rYUBjaHJv bWl1bS5vcmc+Cj4gPiBDYzogQnJpYW4gTm9ycmlzIDxicmlhbm5vcnJpc0BjaHJvbWl1bS5vcmc+ Cj4gPiBDYzogRGFuaWVsIERyYWtlIDxkcmFrZUBlbmRsZXNzbS5jb20+Cj4gPiBTaWduZWQtb2Zm LWJ5OiBLYWktSGVuZyBGZW5nIDxrYWkuaGVuZy5mZW5nQGNhbm9uaWNhbC5jb20+Cj4gPiAKPiA+ IC0tLQo+ID4gZHJpdmVycy91c2IvY29yZS9xdWlya3MuYyB8IDMgKysrCj4gPiAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9j b3JlL3F1aXJrcy5jIGIvZHJpdmVycy91c2IvY29yZS9xdWlya3MuYwo+ID4gaW5kZXggYTEwYjM0 NmI5Nzc3Li45Njk1MTEwNGM0NWIgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9jb3JlL3F1 aXJrcy5jCj4gPiArKysgYi9kcml2ZXJzL3VzYi9jb3JlL3F1aXJrcy5jCj4gPiBAQCAtMTk3LDYg KzE5Nyw5IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgdXNiX2RldmljZV9pZCB1c2JfcXVpcmtfbGlz dFtdID0gewo+ID4gCXsgVVNCX0RFVklDRSgweDBiMDUsIDB4MTdlMCksIC5kcml2ZXJfaW5mbyA9 Cj4gPiAJCQlVU0JfUVVJUktfSUdOT1JFX1JFTU9URV9XQUtFVVAgfSwKPiA+IAo+ID4gKwkvKiBR Q0EgUm9tZSBCbHVldG9vdGggaW4gRGVsbCBEVzE4MjAgd2lyZWxlc3MgbW9kdWxlICovCj4gPiAr CXsgVVNCX0RFVklDRSgweDBjZjMsIDB4ZTAwNyksIC5kcml2ZXJfaW5mbyA9IFVTQl9RVUlSS19S RVNFVF9SRVNVTUUgfSwKPiA+ICsKPiAKPiBjYW4gSSBnZXQgYW4gQUNLIGZyb20geW91IHRvIHRh a2UgdGhpcyBwYXRjaCB0aHJvdWdoIGJsdWV0b290aC1uZXh0IHRyZWU/IE9yIGFyZSB5b3UgcGxh bm5pbmcgdG8gdGFrZSBpdD8KCkl0J3Mgbm90IGluIG15IHF1ZXVlIGF0IGFsbCwgc28gSSBkaWRu J3QgZXZlbiBoYXZlIHRoZSBjaGFuY2UgdG8gdGFrZSBpdAo6KQoKQWNrZWQtYnk6IEdyZWcgS3Jv YWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5vcmc+Ci0tLQpUbyB1bnN1YnNjcmli ZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBp bgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3Jl IG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZv Lmh0bWwK