From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: alexander.levin@verizon.com
Cc: Ido Schimmel <idosch@idosch.org>, Willy Tarreau <w@1wt.eu>,
Wei Wang <weiwan@google.com>, Martin KaFai Lau <kafai@fb.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Chris Rankin <rankincj@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: BUG warnings in 4.14.9
Date: Wed, 27 Dec 2017 13:57:31 +0100 [thread overview]
Message-ID: <20171227125731.GA5771@kroah.com> (raw)
In-Reply-To: <20171227042459.cm7hgti47rkmwf3d@sasha-lappy>
On Wed, Dec 27, 2017 at 04:25:00AM +0000, alexander.levin@verizon.com wrote:
> On Tue, Dec 26, 2017 at 10:54:37PM +0200, Ido Schimmel wrote:
> >On Tue, Dec 26, 2017 at 07:59:55PM +0100, Willy Tarreau wrote:
> >> Guys,
> >>
> >> Chris reported the bug below and confirmed that reverting commit
> >> 9704f81 (ipv6: grab rt->rt6i_ref before allocating pcpu rt) seems to
> >> have fixed the issue for him. This patch is a94b9367 in mainline.
> >>
> >> I personally have no opinion on the patch, just found it because it
> >> was the only one touching this area between 4.14.8 and 4.14.9 :-)
> >>
> >> Should this be reverted or maybe fixed differently ?
> >
> >Maybe I'm missing something, but how come this patch even made its way
> >into 4.14.y? It's part of a series to RCU-ify IPv6 FIB lookup that went
> >into 4.15.
> >
> >Anyway, the mentioned bug was already fixed by commit 951f788a80ff
> >("ipv6: fix a BUG in rt6_get_pcpu_route()") when the code was still in
> >net-next.
>
> Uh, you're right. Greg, please just revert 9704f81. Thanks!
Now reverted, sorry about this.
greg k-h
next prev parent reply other threads:[~2017-12-27 12:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-26 1:49 BUG warnings in 4.14.9 Chris Rankin
2017-12-26 6:21 ` Willy Tarreau
2017-12-26 9:54 ` Chris Rankin
2017-12-26 18:59 ` Willy Tarreau
2017-12-26 20:54 ` Ido Schimmel
2017-12-27 4:25 ` alexander.levin
2017-12-27 12:57 ` Greg Kroah-Hartman [this message]
2017-12-26 23:08 ` alexander.levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227125731.GA5771@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.levin@verizon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rankincj@gmail.com \
--cc=stable@vger.kernel.org \
--cc=w@1wt.eu \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.