From: Greg KH <gregkh@linuxfoundation.org>
To: Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
alex.lemberg@wdc.com
Subject: Re: [PATCH v2 7/9] ufs: sysfs: unit descriptor
Date: Wed, 27 Dec 2017 16:23:06 +0100 [thread overview]
Message-ID: <20171227152306.GH20967@kroah.com> (raw)
In-Reply-To: <1514387627-27817-8-git-send-email-stanislav.nijnikov@wdc.com>
On Wed, Dec 27, 2017 at 05:13:45PM +0200, Stanislav Nijnikov wrote:
> This patch introduces a sysfs group entry for the UFS unit descriptor
> parameters. The group adds "unit_descriptor" folder under the corresponding
> SCSI device sysfs entry (/sys/class/scsi_device/*/device/). The parameters
> are shown as hexadecimal numbers. The full information about the parameters
> could be found at UFS specifications 2.1.
> In addition the patch presents an additional field in the
> scsi_host_template structure - struct attribute_group **sdev_group.
> This field allows to define groups of attributes. It will provide an
> ability to use binary attributes in addition to device attributes and
> to group them under subfolders if necessary.
>
> Signed-off-by: Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
> ---
> Documentation/ABI/testing/sysfs-driver-ufs | 108 +++++++++++++++++++++++++++++
> drivers/scsi/scsi_sysfs.c | 14 ++++
> drivers/scsi/ufs/ufs-sysfs.c | 58 ++++++++++++++++
> drivers/scsi/ufs/ufs-sysfs.h | 3 +
> drivers/scsi/ufs/ufs.h | 11 +++
> drivers/scsi/ufs/ufshcd.c | 23 ++----
> drivers/scsi/ufs/ufshcd.h | 15 ++++
> include/scsi/scsi_host.h | 6 ++
> 8 files changed, 222 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs b/Documentation/ABI/testing/sysfs-driver-ufs
> index 736280e..5ff8dfa 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -489,4 +489,112 @@ Contact: Stanislav Nijnikov <stanislav.nijnikov@wdc.com>
> Description: This file contains a product revision string. The full
> information about the descriptor could be found at
> UFS specifications 2.1.
> + The file is read only.
> +
> +
> +What: /sys/class/scsi_device/*/device/unit_descriptor/boot_lun_id
> +Date: August 2017
Minor nit for all of these, August 2017 was a few months ago :)
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2017-12-27 15:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 15:13 [PATCH v2 0/9] ufs: sysfs: read-only access to device descriptors, attributes and flags Stanislav Nijnikov
2017-12-27 15:13 ` [PATCH v2 1/9] ufs: sysfs: device descriptor Stanislav Nijnikov
2017-12-27 15:19 ` Greg KH
2017-12-27 15:20 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 2/9] ufs: sysfs: interconnect descriptor Stanislav Nijnikov
2017-12-27 15:20 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 3/9] ufs: sysfs: geometry descriptor Stanislav Nijnikov
2017-12-27 15:20 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 4/9] ufs: sysfs: health descriptor Stanislav Nijnikov
2017-12-27 15:21 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 5/9] ufs: sysfs: power descriptor Stanislav Nijnikov
2017-12-27 15:22 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 6/9] ufs: sysfs: string descriptors Stanislav Nijnikov
2017-12-27 15:22 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 7/9] ufs: sysfs: unit descriptor Stanislav Nijnikov
2017-12-27 15:23 ` Greg KH [this message]
2017-12-27 15:13 ` [PATCH v2 8/9] ufs: sysfs: flags Stanislav Nijnikov
2017-12-27 15:23 ` Greg KH
2017-12-27 15:13 ` [PATCH v2 9/9] ufs: sysfs: attributes Stanislav Nijnikov
2017-12-27 15:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227152306.GH20967@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alex.lemberg@wdc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stanislav.nijnikov@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.