All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Rob Herring <robh@kernel.org>
Cc: Dan Murphy <dmurphy@ti.com>, Mark Rutland <mark.rutland@arm.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux LED Subsystem <linux-leds@vger.kernel.org>
Subject: Re: [PATCH] dt: bindings: as3645a: Fix the example node
Date: Wed, 27 Dec 2017 22:19:45 +0100	[thread overview]
Message-ID: <20171227211945.GA9205@amd> (raw)
In-Reply-To: <CAL_JsqKG2TWLTREqNecy_3pOqLFJWa4SM4G4yzyKsZqW7opDvw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1622 bytes --]

On Thu 2017-12-07 09:42:29, Rob Herring wrote:
> On Wed, Dec 6, 2017 at 4:32 PM, Dan Murphy <dmurphy@ti.com> wrote:
> > Rob
> >
> > On 12/06/2017 03:52 PM, Rob Herring wrote:
> >> On Tue, Dec 05, 2017 at 07:36:37AM -0600, Dan Murphy wrote:
> >>> Fix the address-cells and size-cells example node
> >>> to reflect to the correct representation.
> >>>
> >>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> >>> ---
> >>>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 4 ++--
> >>>  1 file changed, 2 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> index fdc40e354a64..8a49ccfec29b 100644
> >>> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> >>> @@ -59,8 +59,8 @@ Example
> >>>  =======
> >>>
> >>>      as3645a@30 {
> >>> -            #address-cells: 1
> >>> -            #size-cells: 0
> >>> +            #address-cells = <1>;
> >>> +            #size-cells = <0>;
> >>>              reg = <0x30>;
> >>>              compatible = "ams,as3645a";
> >>
> >> Convention is also we put compatible first.
> >>
> >
> > OK I will move that too for v2.
> >
> > Can that be in the same patch or do you want a separate patch?
> 
> Same patch is fine.

For fixed patch:

Signed-off-by: Pavel Machek <pavel@ucw.cz>

Thanks,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      reply	other threads:[~2017-12-27 21:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 13:36 [PATCH] dt: bindings: as3645a: Fix the example node Dan Murphy
2017-12-05 13:36 ` Dan Murphy
     [not found] ` <20171205133637.30022-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-05 20:03   ` Dan Murphy
2017-12-05 20:03     ` Dan Murphy
2017-12-06 21:52 ` Rob Herring
2017-12-06 22:32   ` Dan Murphy
2017-12-06 22:32     ` Dan Murphy
2017-12-07 15:42     ` Rob Herring
2017-12-27 21:19       ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171227211945.GA9205@amd \
    --to=pavel@ucw.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.