From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-next 4/4] RDMA/vmw_pvrdma: Remove usage of BIT() from UAPI header
Date: Wed, 27 Dec 2017 21:49:13 -0700 [thread overview]
Message-ID: <20171228044913.GC5343@ziepe.ca> (raw)
In-Reply-To: <20171220192721.GA32622-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
On Wed, Dec 20, 2017 at 11:27:28AM -0800, Bryan Tan wrote:
> BIT() should not be used in the UAPI header. Remove it.
>
> Signed-off-by: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
> include/uapi/rdma/vmw_pvrdma-abi.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/rdma/vmw_pvrdma-abi.h b/include/uapi/rdma/vmw_pvrdma-abi.h
> index 4007cac..02ca0d0 100644
> +++ b/include/uapi/rdma/vmw_pvrdma-abi.h
> @@ -52,14 +52,14 @@
> #define PVRDMA_UVERBS_ABI_VERSION 3 /* ABI Version. */
> #define PVRDMA_UAR_HANDLE_MASK 0x00FFFFFF /* Bottom 24 bits. */
> #define PVRDMA_UAR_QP_OFFSET 0 /* QP doorbell. */
> -#define PVRDMA_UAR_QP_SEND BIT(30) /* Send bit. */
> -#define PVRDMA_UAR_QP_RECV BIT(31) /* Recv bit. */
> +#define PVRDMA_UAR_QP_SEND (1 << 30) /* Send bit. */
> +#define PVRDMA_UAR_QP_RECV (1 << 31) /* Recv bit. */
I changed the '1<<31' to '1UL<<31' when I applied this to for-next,
the constants should be unsigned to avoid problems with sign
extensions on the high bit.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-28 4:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 19:23 [PATCH for-next 0/4] vmw_pvrdma cleanup and style fixes Bryan Tan
[not found] ` <20171220192305.GA28403-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-12-20 19:24 ` [PATCH for-next 1/4] RDMA/vmw_pvrdma: Clarify QP and CQ is_kernel logic Bryan Tan
2017-12-20 19:26 ` [PATCH for-next 2/4] RDMA/vmw_pvrdma: Use more specific sizeof in kcalloc Bryan Tan
2017-12-20 19:27 ` [PATCH for-next 3/4] RDMA/vmw_pvrdma: Use refcount_t instead of atomic_t Bryan Tan
2017-12-20 19:27 ` [PATCH for-next 4/4] RDMA/vmw_pvrdma: Remove usage of BIT() from UAPI header Bryan Tan
[not found] ` <20171220192721.GA32622-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-12-21 13:00 ` Leon Romanovsky
[not found] ` <20171221130034.GH2942-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-21 16:34 ` Jason Gunthorpe
[not found] ` <20171221163433.GD20015-uk2M96/98Pc@public.gmane.org>
2017-12-21 17:17 ` Leon Romanovsky
2017-12-28 4:49 ` Jason Gunthorpe [this message]
2017-12-28 4:49 ` [PATCH for-next 0/4] vmw_pvrdma cleanup and style fixes Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228044913.GC5343@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.