Re: [PATCH v2] iio/bmp280-core.c: Read calibration data in probe

[Stefan Tatschner <stefan.tatschner@gmail.com>]

Hi,

On Tue, Dec 12, 2017 at 09:35:37PM +0100, Stefan Tatschner wrote:
> This patch affects BME280 and BMP280. The readout of the calibration
> data is moved to the probe function. Each sensor data access triggered
> reading the full calibration data before this patch. According to the
> datasheet, Section 4.4.2., the calibration data is stored in non-volatile
> memory.
> 
> Since the calibration data does not change, and cannot be changed by the
> user, we can reduce bus traffic by reading the calibration data once.
> Additionally, proper organization of the data types enables removing
> some odd casts in the compensation formulas.
> 
> Signed-off-by: Stefan Tatschner <stefan.tatschner@gmail.com>

what's the status of this? Are there any further opinions on this?  I am
happy to address your comments on my first kernel patch. :)

Stefan

> ---
> 
> v2 changes:
>     - readded the type casts in humidity calibration values
>     - fix typo
> 
>  drivers/iio/pressure/bmp280-core.c | 205 ++++++++++++++++++++++++-------------
>  1 file changed, 134 insertions(+), 71 deletions(-)