From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/nut: workaround parallel build issue
Date: Thu, 28 Dec 2017 14:24:22 +0100 [thread overview]
Message-ID: <20171228132422.GC3428@scaer> (raw)
In-Reply-To: <87tvwduxml.fsf@dell.be.48ers.dk>
On 2017-12-26 19:56 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > The conditions are not trivial to reproduce, but it can happen that the
> > headers are not fully regenerated by the time they are included.
>
> > Since they already are present and current in the archive, just patch
> > out their generation from the Makefile.
>
> > Fixes:
> > http://autobuild.buildroot.org/results/523/5231ff39a0839ec5e1962662004214d4b0773068/
> > http://autobuild.buildroot.org/results/5a7/5a75d44c028e77b58f0fd9ab794952f2b477dd84/
>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Thanks, but doesn't it make more sense to just use MAKE1 instead of such
> a non-upstreamable patch?
>
> Nut is not a very big package and has no reverse dependencies, so the
> impact of MAKE1 is quite small.
I timed a nut build, and indeed the build time for a non-parallel build
is split as such (on an otherwise-unloaded machine):
14:18:03 >>> nut 2.7.4 Extracting
14:18:03 >>> nut 2.7.4 Patching
14:18:03 >>> nut 2.7.4 Updating config.sub and config.guess
14:18:03 >>> nut 2.7.4 Configuring
14:18:03 >>> nut 2.7.4 Autoreconfiguring
14:18:10 >>> nut 2.7.4 Patching libtool
14:18:15 >>> nut 2.7.4 Building
14:18:37 >>> nut 2.7.4 Installing to target
So it is about 34s, of which 22s to build, while a parallel build would
take just about 8s to build.
I'll send a patch to use MAKE1.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2017-12-28 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-23 15:29 [Buildroot] [PATCH] package/nut: workaround parallel build issue Yann E. MORIN
2017-12-26 18:56 ` Peter Korsgaard
2017-12-28 13:24 ` Yann E. MORIN [this message]
2017-12-28 22:11 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228132422.GC3428@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.