From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Jeff Hostetler" <jeffhost@microsoft.com>,
"Johannes Sixt" <j6t@kdbg.org>,
git-for-windows@googlegroups.com,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default
Date: Thu, 28 Dec 2017 14:07:42 +0000 [thread overview]
Message-ID: <20171228140742.26735-3-avarab@gmail.com> (raw)
In-Reply-To: <20171228140742.26735-1-avarab@gmail.com>
In-Reply-To: <20171227233912.GB181628@aiede.mtv.corp.google.com>
Using BLK_SHA1 in lieu of the OpenSSL routines was done in
9bccfcdbff ("Windows: use BLK_SHA1 again", 2009-10-22), since DC_SHA1
is now the default for git in general it makes sense for Windows to
use that too, this looks like something that was missed back in
e6b07da278 ("Makefile: make DC_SHA1 the default", 2017-03-17).
As noted in 2cfc70f0de ("mingw: use OpenSSL's SHA-1 routines",
2017-02-09) OpenSSL has a performance benefit compared to BLK_SHA1 on
MinGW, so perhaps that and the Windows default should be changed
around again. That's a topic for another series, it seems clear that
this specific flag is nobody's explicit intention.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
config.mak.uname | 1 -
1 file changed, 1 deletion(-)
diff --git a/config.mak.uname b/config.mak.uname
index 685a80d138..6a862abd35 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -361,7 +361,6 @@ ifeq ($(uname_S),Windows)
NO_REGEX = YesPlease
NO_GETTEXT = YesPlease
NO_PYTHON = YesPlease
- BLK_SHA1 = YesPlease
ETAGS_TARGET = ETAGS
NO_INET_PTON = YesPlease
NO_INET_NTOP = YesPlease
--
2.15.1.424.g9478a66081
next prev parent reply other threads:[~2017-12-28 14:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 23:00 [PATCH 0/2] When DC_SHA1 was made the default we missed a spot Ævar Arnfjörð Bjarmason
2017-12-27 23:00 ` [PATCH 1/2] Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1 Ævar Arnfjörð Bjarmason
2017-12-27 23:39 ` Jonathan Nieder
2017-12-28 14:07 ` [PATCH v2 0/2] When DC_SHA1 was made the default we missed a spot Ævar Arnfjörð Bjarmason
2017-12-28 14:07 ` [PATCH v2 1/2] Makefile: NO_OPENSSL=1 should no longer imply BLK_SHA1=1 Ævar Arnfjörð Bjarmason
2017-12-28 19:05 ` Jonathan Nieder
2017-12-28 14:07 ` Ævar Arnfjörð Bjarmason [this message]
2017-12-28 19:04 ` [PATCH v2 2/2] Windows: stop supplying BLK_SHA1=YesPlease by default Jonathan Nieder
2018-01-04 17:33 ` Johannes Schindelin
2018-01-04 18:30 ` Ævar Arnfjörð Bjarmason
2018-01-05 18:52 ` Junio C Hamano
2017-12-27 23:00 ` [PATCH " Ævar Arnfjörð Bjarmason
2017-12-27 23:42 ` Jonathan Nieder
2017-12-28 13:47 ` Ævar Arnfjörð Bjarmason
2018-01-04 17:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228140742.26735-3-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git-for-windows@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.