All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramon Fried <rfried@codeaurora.org>
To: openembedded-devel@lists.openembedded.org
Subject: [meta-oe][rocko][PATCH] gpsd: fix /etc/default/gpsd ALTERNATIVES logic
Date: Thu, 28 Dec 2017 16:56:58 +0200	[thread overview]
Message-ID: <20171228145658.24259-1-rfried@codeaurora.org> (raw)

From: Martin Kelly <mkelly@xevo.com>

The ALTERNATIVES logic for the /etc/default/gpsd file is broken,
specifying ALTERNATIVE_LINK without brackets. In addition, it refers to
ALTERNATIVE_PATH, which update-alternatives.bbclass doesn't use.

With this patch, /etc/default/gpsd correctly gets a default link
pointing to /etc/default/gpsd.default. Currently, no such link gets
created, and gpsd starts off disabled by default since it's missing this
config file.

Signed-off-by: Martin Kelly <mkelly@xevo.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
(cherry picked from commit 194f855b44319c7834ba11e6e0a77ef279970a04)
Signed-off-by: Ramon Fried <rfried@codeaurora.org>
---
 meta-oe/recipes-navigation/gpsd/gpsd_3.16.bb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.16.bb b/meta-oe/recipes-navigation/gpsd/gpsd_3.16.bb
index f8e6a2b13..47fed2d97 100644
--- a/meta-oe/recipes-navigation/gpsd/gpsd_3.16.bb
+++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.16.bb
@@ -129,6 +129,5 @@ SYSTEMD_SERVICE_${PN} = "${PN}.socket"
 
 
 ALTERNATIVE_${PN} = "gpsd-defaults"
-ALTERNATIVE_PATH = "${sysconfdir}/default/gpsd.default"
-ALTERNATIVE_LINK = "${sysconfdir}/default/gpsd"
-ALTERNATIVE_TARGET = "${sysconfdir}/default/gpsd.default"
+ALTERNATIVE_LINK_NAME[gpsd-defaults] = "${sysconfdir}/default/gpsd"
+ALTERNATIVE_TARGET[gpsd-defaults] = "${sysconfdir}/default/gpsd.default"
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project



             reply	other threads:[~2017-12-28 15:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 14:56 Ramon Fried [this message]
2018-01-03 18:20 ` [meta-oe][rocko][PATCH] gpsd: fix /etc/default/gpsd ALTERNATIVES logic Martin Kelly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171228145658.24259-1-rfried@codeaurora.org \
    --to=rfried@codeaurora.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.