From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Thu, 28 Dec 2017 10:42:26 -0800 Subject: [PATCH -next] clk: meson-axg: fix return value check in axg_clkc_probe() In-Reply-To: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> References: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> Message-ID: <20171228184226.GO7997@codeaurora.org> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 12/28, Wei Yongjun wrote: > In case of error, the function devm_ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") > Signed-off-by: Wei Yongjun > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 28 Dec 2017 10:42:26 -0800 From: Stephen Boyd To: Wei Yongjun Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Carlo Caione , Kevin Hilman , Qiufang Dai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] clk: meson-axg: fix return value check in axg_clkc_probe() Message-ID: <20171228184226.GO7997@codeaurora.org> References: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> List-ID: On 12/28, Wei Yongjun wrote: > In case of error, the function devm_ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") > Signed-off-by: Wei Yongjun > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Thu, 28 Dec 2017 10:42:26 -0800 Subject: [PATCH -next] clk: meson-axg: fix return value check in axg_clkc_probe() In-Reply-To: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> References: <1514428849-61681-1-git-send-email-weiyongjun1@huawei.com> Message-ID: <20171228184226.GO7997@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12/28, Wei Yongjun wrote: > In case of error, the function devm_ioremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Fixes: 78b4af312f91 ("clk: meson-axg: add clock controller drivers") > Signed-off-by: Wei Yongjun > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project