All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yixian Liu <liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: jgg-uk2M96/98Pc@public.gmane.org,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 for-next 2/2] RDMA/hns: Fix alignment problem of the doorbell
Date: Fri, 29 Dec 2017 08:48:43 +0200	[thread overview]
Message-ID: <20171229064843.GU3494@mtr-leonro.local> (raw)
In-Reply-To: <1514470683-6972-3-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

On Thu, Dec 28, 2017 at 10:18:03PM +0800, Yixian Liu wrote:
> The array defined for doorbell is not guaranteed to be 64 bit
> aligned while we write it to the hardware with 64 bit
> alignment required.
>
> This patch fixes this problem by defining a union for doorbell
> to make sure it 64 bit alignment.
>
> v2 -> v3:
> 1. delete the unnecessary assignment for doorbell64.
>
> v2:
> 1. Consider with Leon's comments, make sure it is 64 bit
>    alignment by assigning the expected value to the u64
>    member of the union type, i.e., assign doorbell array
>    to doorbell64.

Please put changelog after "---", so it won't be visible in git log.
See this patch as an example:
https://lkml.org/lkml/2017/8/18/785

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-12-29  6:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-28 14:18 [PATCH v3 for-next 0/2] Bugfixes for eq support in hns Yixian Liu
     [not found] ` <1514470683-6972-1-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-28 14:18   ` [PATCH v3 for-next 1/2] RDMA/hns: Add detailed comments for mb() call Yixian Liu
     [not found]     ` <1514470683-6972-2-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-28 15:55       ` Jason Gunthorpe
     [not found]         ` <20171228155519.GT25436-uk2M96/98Pc@public.gmane.org>
2017-12-29 10:19           ` Liuyixian (Eason)
2017-12-28 14:18   ` [PATCH v3 for-next 2/2] RDMA/hns: Fix alignment problem of the doorbell Yixian Liu
     [not found]     ` <1514470683-6972-3-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-28 15:57       ` Jason Gunthorpe
     [not found]         ` <20171228155712.GU25436-uk2M96/98Pc@public.gmane.org>
2017-12-29 10:29           ` Liuyixian (Eason)
     [not found]             ` <aa43b6d4-bb56-ed2f-33c9-c047e27a0a59-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-29 17:47               ` Jason Gunthorpe
     [not found]                 ` <20171229174717.GB6513-uk2M96/98Pc@public.gmane.org>
2018-01-02  3:07                   ` Liuyixian (Eason)
2017-12-29  6:48       ` Leon Romanovsky [this message]
     [not found]         ` <20171229064843.GU3494-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-29  7:26           ` Liuyixian (Eason)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171229064843.GU3494@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.