From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] nvme-pci: don't open-code nvme_reset_ctrl
Date: Fri, 29 Dec 2017 10:28:22 +0100 [thread overview]
Message-ID: <20171229092822.GA23197@lst.de> (raw)
In-Reply-To: <20171225133717.4557-1-sagi@grimberg.me>
This looks ok, but I really having real functionality inside a WARN_ON
statement as that obsufcate? things. But I don't think we even really
need the WARN_ON here at all.
prev parent reply other threads:[~2017-12-29 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 13:37 [PATCH] nvme-pci: don't open-code nvme_reset_ctrl Sagi Grimberg
2017-12-29 9:28 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229092822.GA23197@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.