From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/waffle: new package
Date: Fri, 29 Dec 2017 23:25:38 +0100 [thread overview]
Message-ID: <20171229232538.03219251@windsurf.lan> (raw)
In-Reply-To: <20171225154923.18773-2-romain.naour@gmail.com>
Hello,
On Mon, 25 Dec 2017 16:49:22 +0100, Romain Naour wrote:
> diff --git a/package/waffle/Config.in b/package/waffle/Config.in
> new file mode 100644
> index 0000000000..a9799ef43e
> --- /dev/null
> +++ b/package/waffle/Config.in
> @@ -0,0 +1,30 @@
> +comment "waffle needs an OpenGL GL or EGL provider"
> + depends on BR2_PACKAGE_XORG7 || BR2_PACKAGE_WAYLAND
> + depends on !BR2_PACKAGE_HAS_LIBGL && !BR2_PACKAGE_HAS_LIBEGL
> +
> +config BR2_PACKAGE_WAFFLE
> + bool "waffle"
> + depends on BR2_PACKAGE_XORG7 || BR2_PACKAGE_WAYLAND
> + depends on BR2_PACKAGE_HAS_LIBGL || BR2_PACKAGE_HAS_LIBEGL
> + select BR2_PACKAGE_XLIB_LIBX11 if BR2_PACKAGE_XORG7
I'm curious: why are you selecting xlib_libX11, but not libxcb, while
both seem to be needed for X11 support ?
Other than this question, looks good to me.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-12-29 22:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-25 15:49 [Buildroot] [PATCH 1/3] package/python-numpy: add host variant for piglit Romain Naour
2017-12-25 15:49 ` [Buildroot] [PATCH 2/3] package/waffle: new package Romain Naour
2017-12-29 22:25 ` Thomas Petazzoni [this message]
2018-01-05 12:46 ` Romain Naour
2017-12-29 22:27 ` Thomas Petazzoni
2018-01-05 13:03 ` Romain Naour
2017-12-25 15:49 ` [Buildroot] [PATCH 3/3] package/piglit: " Romain Naour
2017-12-25 15:59 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171229232538.03219251@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.