From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,03/49] usb: dwc2: Remove version check in GSNPSID From: Greg Kroah-Hartman Message-Id: <20171230141159.GA8431@kroah.com> Date: Sat, 30 Dec 2017 15:11:59 +0100 To: Minas Harutyunyan Cc: Grigor Tovmasyan , John Youn , Felipe Balbi , "linux-usb@vger.kernel.org" , Gevorg Sahakyan , "stable@vger.kernel.org" List-ID: T24gRnJpLCBEZWMgMjksIDIwMTcgYXQgMDc6NTY6MThQTSArMDAwMCwgTWluYXMgSGFydXR5dW55 YW4gd3JvdGU6Cj4gSGkgR3JlZywKPiAKPiBPbiAxMi8yOS8yMDE3IDg6NTkgUE0sIEdyZWcgS0gg d3JvdGU6Cj4gPiBPbiBUdWUsIERlYyAyNiwgMjAxNyBhdCAwMzoyMjowNVBNICswNDAwLCBHcmln b3IgVG92bWFzeWFuIHdyb3RlOgo+ID4+IEZyb206IEdldm9yZyBTYWhha3lhbiA8c2FoYWt5YW5A c3lub3BzeXMuY29tPgo+ID4+Cj4gPj4gT25seSBjaGVjayB0aGUgSUQgcG9ydGlvbiBvZiB0aGUg R1NOUFNJRCByZWdpc3RlciBhbmQgZG9u4oCZdCBjaGVjawo+ID4+IHRoZSB2ZXJzaW9uLiBUaGlz IHdpbGwgYWxsb3cgdGhlIGRyaXZlciB0byB3b3JrIHdpdGggdmVyc2lvbiA0LjAwYQo+ID4+IGFu ZCBsYXRlciBvZiB0aGUgRFdDX2hzb3RnIElQLgo+ID4+Cj4gPj4gQ2M6IHN0YWJsZUB2Z2VyLmtl cm5lbC5vcmcKPiA+IAo+ID4gRm9yIGJ1Z2ZpeGVzIGxpa2UgdGhpcywgb3Igb3RoZXIgc3RhYmxl IHBhdGNoZXMsIHRoZXkgc2hvdWxkIGFsbCBiZQo+ID4gZmlyc3QgaW4gdGhlIHNlcmllcywgc28g dGhhdCBub25lIG9mIHRoZW0gZGVwZW5lZCBvbiBhbnkgcHJldmlvdXMKPiA+IHBhdGNoZXMuCj4g PiAKPiA+IHRoYW5rcywKPiA+IAo+ID4gZ3JlZyBrLWgKPiA+IAo+IAo+IDEuIE1lbnRpb25lZCBw YXRjaCBzdWJtaXR0ZWQgdG8gbGttbCBhcyBhbG9uZSBwYXRjaCBvbiBEZWMgNiBieSBHZXZvcmcg Cj4gU2FoYWt5YW4gYnV0IHdhcyBpZ25vcmVkIGJ5IGNvbW11bml0eS4KCmxrbWwgaXMgbm90IHdo ZXJlIHRvIHNlbmQgZHdjIHBhdGNoZXMsIHlvdSBrbm93IGJldHRlciB0aGFuIHRoYXQgOikKClRo YXQncyB3aGF0IHNjcmlwdHMvZ2V0X21haW50YWluZXIucGwgaXMgZm9yLCBhbHdheXMgdXNlIHRo YXQuCgo+IDIuIFRoaXMgcGF0Y2ggbm90IGRlcGVuZGVudCBvbiBhbnkgb3RoZXIgcHJldmlvdXMg cGF0Y2hlcyBpbiBzZXJpZXMuCgpIb3cgYXJlIHdlIHN1cHBvc2VkIHRvIGtub3cgdGhhdD8gIEZv ciBzdHVmZiBsaWtlIHRoaXMgdGhhdCBhcmUgYnVnCmZpeGVzIGFuZCBmb3Igc3RhYmxlIGtlcm5l bHMsIHRoZXkgc2hvdWxkIGJlIGluIGEgc2VwYXJhdGUgc2VyaWVzIHNvIHdlCmNhbiBhcHBseSB0 aGVtIHRvIHRoZSBsYXRlc3QgLXJjIHJlbGVhc2UsIGFsbCBvZiB0aGUgY2xlYW51cHMgYW5kIG5l dwpmZWF0dXJlcyBzaG91bGQgYmUgaW4gYSBzZXBhcmF0ZSBwYXRjaCBzZXJpZXMuCgpBbnl3YXks IGFzIG90aGVycyBzYWlkLCA0OSBwYXRjaGVzIGlzIGEgbG90LCBsZXQncyB3YWl0IGZvciB0aGUK bWFpbnRhaW5lcnMgdG8gcmV0dXJuIGZyb20gdmFjYXRpb24gYmVmb3JlIGFueXRoaW5nIGVsc2Uu Li4KCnRoYW5rcywKCmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDog c2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1l c3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0 ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:53946 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbdL3OL4 (ORCPT ); Sat, 30 Dec 2017 09:11:56 -0500 Date: Sat, 30 Dec 2017 15:11:59 +0100 From: Greg KH To: Minas Harutyunyan Cc: Grigor Tovmasyan , John Youn , Felipe Balbi , "linux-usb@vger.kernel.org" , Gevorg Sahakyan , "stable@vger.kernel.org" Subject: Re: [PATCH v3 03/49] usb: dwc2: Remove version check in GSNPSID Message-ID: <20171230141159.GA8431@kroah.com> References: <20171229165934.GA7251@kroah.com> <410670D7E743164D87FA6160E7907A560113A53D12@am04wembxa.internal.synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <410670D7E743164D87FA6160E7907A560113A53D12@am04wembxa.internal.synopsys.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Dec 29, 2017 at 07:56:18PM +0000, Minas Harutyunyan wrote: > Hi Greg, > > On 12/29/2017 8:59 PM, Greg KH wrote: > > On Tue, Dec 26, 2017 at 03:22:05PM +0400, Grigor Tovmasyan wrote: > >> From: Gevorg Sahakyan > >> > >> Only check the ID portion of the GSNPSID register and don’t check > >> the version. This will allow the driver to work with version 4.00a > >> and later of the DWC_hsotg IP. > >> > >> Cc: stable@vger.kernel.org > > > > For bugfixes like this, or other stable patches, they should all be > > first in the series, so that none of them depened on any previous > > patches. > > > > thanks, > > > > greg k-h > > > > 1. Mentioned patch submitted to lkml as alone patch on Dec 6 by Gevorg > Sahakyan but was ignored by community. lkml is not where to send dwc patches, you know better than that :) That's what scripts/get_maintainer.pl is for, always use that. > 2. This patch not dependent on any other previous patches in series. How are we supposed to know that? For stuff like this that are bug fixes and for stable kernels, they should be in a separate series so we can apply them to the latest -rc release, all of the cleanups and new features should be in a separate patch series. Anyway, as others said, 49 patches is a lot, let's wait for the maintainers to return from vacation before anything else... thanks, greg k-h