All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "François Valenduc" <francoisvalenduc@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: Linux 4.14.10
Date: Sat, 30 Dec 2017 16:54:53 +0100	[thread overview]
Message-ID: <20171230155453.GA2088@kroah.com> (raw)
In-Reply-To: <fda8064b-fffa-8e61-3891-ce2b2f791fd7@gmail.com>

On Sat, Dec 30, 2017 at 04:48:32PM +0100, Fran�ois Valenduc wrote:
> 
> 
> Le 29/12/17 � 18:42, Greg KH a �crit�:
> > On Fri, Dec 29, 2017 at 06:38:15PM +0100, Fran�ois Valenduc wrote:
> >> Le 29/12/17 � 18:32, Greg KH a �crit�:
> >>> On Fri, Dec 29, 2017 at 06:18:18PM +0100, Fran�ois Valenduc wrote:
> >>>> No solution found to the permissions on tools/objtool/sync-check.sh  ?
> >>> Is the permission not correct in the repo?  Is it not correct in the
> >>> patch I sent out in response to this?
> >>>
> >>>> git or patch is not smart enough for that ? It's obviously extremely
> >>>> easy to solve the problem, but I find that rather strange.
> >>> git and patch handle it just fine, quilt has issues, which I worked
> >>> around very easily.  Are you having problems with the git tree as-is?
> >>>
> >>> thanks,
> >>>
> >>> greg k-h
> >> It seems I messed up with enigmail. So in case you couldn't read my
> >> reply, I send it again.
> >>
> >> I didn't see the posts of Toralf Forster before replying to your
> >> annoucement. But my problem is exactly the same. I extracted the patch
> >> from git (with git diff v4.14.9..v4.14.10). The permissions are also
> >> wrong if I download the patch from kernel.org. In both cases,
> >> sync-check.sh is not executable.
> > That's fine, but when you apply the patch, you need to keep the file
> > mode.  So be careful as to how you apply it.
> >
> > I just got told that there's a patch in Andrew's tree that fixes this
> > (it doesn't rely on the mode of the file.)  Hopefully it gets into
> > Linus's tree soon and then I can queue it up into the stable tree to
> > help people who don't only use git.
> >
> > thanks,
> >
> > greg k-h
> 
> I tried like this:
> git diff v4.14.9..v4.14.10 | (cd /usr/src/linux-4.14 && patch -p1 )
> or xzcat .../patch-4.14.9-10.xz | patch -p1
> As I said, in both cases, sync-check.sh is not executable.
> 
> But if I do git archive --prefix=linux-4.14/  | (cd ../ && tar xvfp - ), sync-script.sh is executable.
> 
> Would there be something wrong with the patch command ?

Yes, patch is the problem here, it's not keeping the file permission,
sorry.

greg k-h

  reply	other threads:[~2017-12-30 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-29 17:10 Linux 4.14.10 Greg KH
2017-12-29 17:11 ` Greg KH
2017-12-29 17:18 ` François Valenduc
2017-12-29 17:32   ` Greg KH
2017-12-29 17:38     ` François Valenduc
2017-12-29 17:42       ` Greg KH
2017-12-30 15:48         ` François Valenduc
2017-12-30 15:54           ` Greg KH [this message]
2018-01-15 22:07         ` Holger Hoffstätte
2018-01-16  5:54           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171230155453.GA2088@kroah.com \
    --to=greg@kroah.com \
    --cc=francoisvalenduc@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.