From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f67.google.com ([209.85.215.67]:40913 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751012AbdLaSot (ORCPT ); Sun, 31 Dec 2017 13:44:49 -0500 Received: by mail-lf0-f67.google.com with SMTP id u84so32398861lff.7 for ; Sun, 31 Dec 2017 10:44:48 -0800 (PST) From: Sergei Shtylyov Message-Id: <20171231184444.642619406@cogentembedded.com> Date: Sun, 31 Dec 2017 21:41:35 +0300 To: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org ("open list:RENESAS ETHERNET DRIVERS") Subject: [PATCH 1/2] ravb: kill redundant check in the probe() method MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Disposition: inline; filename=ravb-kill-redundant-check-in-the-probe-method.patch Cc: Sergei Shtylyov Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Browsing thru the driver diassembly, I noticed that gcc was able to figure out that the 'ndev' pointer is always non-NULL when calling free_netdev() on the probe() method's error path and thus skip that redundant NULL check... gcc is smart, be like gcc! :-) Signed-off-by: Sergei Shtylyov --- drivers/net/ethernet/renesas/ravb_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: net-next/drivers/net/ethernet/renesas/ravb_main.c =================================================================== --- net-next.orig/drivers/net/ethernet/renesas/ravb_main.c +++ net-next/drivers/net/ethernet/renesas/ravb_main.c @@ -2205,8 +2205,7 @@ out_dma_free: if (chip_id != RCAR_GEN2) ravb_ptp_stop(ndev); out_release: - if (ndev) - free_netdev(ndev); + free_netdev(ndev); pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev);