From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH] ASoC: Intel: Skylake: Disable clock gating
 during firmware and library download
Date: Tue, 2 Jan 2018 16:14:37 +0530
Message-ID: <20180102104437.GA18649@localhost>
References: <20180102092957.14091-1-guneshwor.o.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by alsa0.perex.cz (Postfix) with ESMTP id A44EA2668F0
 for <alsa-devel@alsa-project.org>; Tue,  2 Jan 2018 11:40:33 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <20180102092957.14091-1-guneshwor.o.singh@intel.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Guneshwor Singh <guneshwor.o.singh@intel.com>
Cc: ALSA <alsa-devel@alsa-project.org>, Takashi Iwai <tiwai@suse.de>, Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Patches Audio <patches.audio@intel.com>, Mark Brown <broonie@kernel.org>, Sanyog Kale <sanyog.r.kale@intel.com>
List-Id: alsa-devel@alsa-project.org

On Tue, Jan 02, 2018 at 02:59:57PM +0530, Guneshwor Singh wrote:
> From: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> 
> During firmware and library download, sometimes it is observed that
> firmware and library download is timed-out resulting into probe failure.
> 
> This patch disables dynamic clock gating while firmware and library
> download.
> 
> Signed-off-by: Pardha Saradhi K <pardha.saradhi.kesapragada@intel.com>
> Signed-off-by: Sanyog Kale <sanyog.r.kale@intel.com>
> Signed-off-by: Guneshwor Singh <guneshwor.o.singh@intel.com>

Acked-By: Vinod Koul <vinod.koul@intel.com>

> ---
>  sound/soc/intel/skylake/skl-messages.c | 4 ++++
>  sound/soc/intel/skylake/skl-pcm.c      | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
> index 81ee1118ed71..8cbf080c38b3 100644
> --- a/sound/soc/intel/skylake/skl-messages.c
> +++ b/sound/soc/intel/skylake/skl-messages.c
> @@ -417,7 +417,11 @@ int skl_resume_dsp(struct skl *skl)
>  	if (skl->skl_sst->is_first_boot == true)
>  		return 0;
>  
> +	/* disable dynamic clock gating during fw and lib download */
> +	ctx->enable_miscbdcge(ctx->dev, false);
> +
>  	ret = skl_dsp_wake(ctx->dsp);
> +	ctx->enable_miscbdcge(ctx->dev, true);
>  	if (ret < 0)
>  		return ret;
>  
> diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
> index 8d0895b409b5..e46828533826 100644
> --- a/sound/soc/intel/skylake/skl-pcm.c
> +++ b/sound/soc/intel/skylake/skl-pcm.c
> @@ -1343,7 +1343,11 @@ static int skl_platform_soc_probe(struct snd_soc_platform *platform)
>  			return -EIO;
>  		}
>  
> +		/* disable dynamic clock gating during fw and lib download */
> +		skl->skl_sst->enable_miscbdcge(platform->dev, false);
> +
>  		ret = ops->init_fw(platform->dev, skl->skl_sst);
> +		skl->skl_sst->enable_miscbdcge(platform->dev, true);
>  		if (ret < 0) {
>  			dev_err(platform->dev, "Failed to boot first fw: %d\n", ret);
>  			return ret;
> -- 
> 2.15.1
> 

-- 
~Vinod