From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB: usbip: remove useless call in usbip_recv From: "Gustavo A. R. Silva" Message-Id: <20180102140206.GA26171@embeddedor.com> Date: Tue, 2 Jan 2018 08:02:06 -0600 To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" List-ID: Q2FsbGluZyBtc2dfZGF0YV9sZWZ0KCZtc2cpIGlzIG9ubHkgdXNlZnVsIGZvciBpdHMgcmV0dXJu IHZhbHVlLAp3aGljaCBpbiB0aGlzIHBhcnRpY3VsYXIgY2FzZSBpcyBpZ25vcmVkLgoKRml4IHRo aXMgYnkgcmVtb3Zpbmcgc3VjaCBjYWxsLgoKQWRkcmVzc2VzLUNvdmVyaXR5LUlEOiAxNDI3MDgw CkZpeGVzOiA5MDEyMGQxNWY0YzMgKCJ1c2JpcDogcHJldmVudCBsZWFraW5nIHNvY2tldCBwb2lu dGVyIGFkZHJlc3MgaW4gbWVzc2FnZXMiKQpTaWduZWQtb2ZmLWJ5OiBHdXN0YXZvIEEuIFIuIFNp bHZhIDxnYXJzaWx2YUBlbWJlZGRlZG9yLmNvbT4KLS0tCiBkcml2ZXJzL3VzYi91c2JpcC91c2Jp cF9jb21tb24uYyB8IDEgLQogMSBmaWxlIGNoYW5nZWQsIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9kcml2ZXJzL3VzYi91c2JpcC91c2JpcF9jb21tb24uYyBiL2RyaXZlcnMvdXNiL3VzYmlw L3VzYmlwX2NvbW1vbi5jCmluZGV4IDdiMjE5ZDkuLmI1YWY2ZmMgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvdXNiL3VzYmlwL3VzYmlwX2NvbW1vbi5jCisrKyBiL2RyaXZlcnMvdXNiL3VzYmlwL3VzYmlw X2NvbW1vbi5jCkBAIC0zMjUsNyArMzI1LDYgQEAgaW50IHVzYmlwX3JlY3Yoc3RydWN0IHNvY2tl dCAqc29jaywgdm9pZCAqYnVmLCBpbnQgc2l6ZSkKIAl1c2JpcF9kYmdfeG1pdCgiZW50ZXJcbiIp OwogCiAJZG8gewotCQltc2dfZGF0YV9sZWZ0KCZtc2cpOwogCQlzb2NrLT5zay0+c2tfYWxsb2Nh dGlvbiA9IEdGUF9OT0lPOwogCiAJCXJlc3VsdCA9IHNvY2tfcmVjdm1zZyhzb2NrLCAmbXNnLCBN U0dfV0FJVEFMTCk7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbeABOCL (ORCPT + 1 other); Tue, 2 Jan 2018 09:02:11 -0500 Received: from gateway31.websitewelcome.com ([192.185.143.33]:23949 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbeABOCJ (ORCPT ); Tue, 2 Jan 2018 09:02:09 -0500 Date: Tue, 2 Jan 2018 08:02:06 -0600 From: "Gustavo A. R. Silva" To: Valentina Manea , Shuah Khan , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] USB: usbip: remove useless call in usbip_recv Message-ID: <20180102140206.GA26171@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.172.31.204 X-Source-L: No X-Exim-ID: 1eWN8q-000YWn-4z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [187.172.31.204]:55362 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Calling msg_data_left(&msg) is only useful for its return value, which in this particular case is ignored. Fix this by removing such call. Addresses-Coverity-ID: 1427080 Fixes: 90120d15f4c3 ("usbip: prevent leaking socket pointer address in messages") Signed-off-by: Gustavo A. R. Silva --- drivers/usb/usbip/usbip_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/usbip/usbip_common.c b/drivers/usb/usbip/usbip_common.c index 7b219d9..b5af6fc 100644 --- a/drivers/usb/usbip/usbip_common.c +++ b/drivers/usb/usbip/usbip_common.c @@ -325,7 +325,6 @@ int usbip_recv(struct socket *sock, void *buf, int size) usbip_dbg_xmit("enter\n"); do { - msg_data_left(&msg); sock->sk->sk_allocation = GFP_NOIO; result = sock_recvmsg(sock, &msg, MSG_WAITALL); -- 2.7.4