From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/2] USB: serial: ark3116.c: Remove unused TIOCSSERIAL ioctl case. From: Johan Hovold Message-Id: <20180102145047.GL16993@localhost> Date: Tue, 2 Jan 2018 15:50:47 +0100 To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBEZWMgMTMsIDIwMTcgYXQgMDQ6NDQ6NTVQTSArMDMwMCwgTWlraGFpbCBaYXl0c2V2 IHdyb3RlOgo+IFRoZSBwYXRjaCByZW1vdmVzIHVudXNlZCBUSU9DU1NFUklBTCBpb2N0bCBjYXNl IGFuZCBhZGRzIHRoZSBkZWZhdWx0IGJsb2NrIAo+IHRvIHRoZSBzd2l0Y2guCj4gCj4gU2lnbmVk LW9mZi1ieTogTWlraGFpbCBaYXl0c2V2IDxmbGFzaGVkQG1haWwucnU+Cj4gLS0tCj4gIGRyaXZl cnMvdXNiL3NlcmlhbC9hcmszMTE2LmMgfCA2ICsrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Vz Yi9zZXJpYWwvYXJrMzExNi5jIGIvZHJpdmVycy91c2Ivc2VyaWFsL2FyazMxMTYuYwo+IGluZGV4 IDIzZDQ2ZWY4Ny4uMmU5NTdjNzZmIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdXNiL3NlcmlhbC9h cmszMTE2LmMKPiArKysgYi9kcml2ZXJzL3VzYi9zZXJpYWwvYXJrMzExNi5jCj4gQEAgLTQxOCwx MCArNDE4LDggQEAgc3RhdGljIGludCBhcmszMTE2X2lvY3RsKHN0cnVjdCB0dHlfc3RydWN0ICp0 dHksCj4gIAkJCXJldHVybiAtRUZBVUxUOwo+ICAKPiAgCQlyZXR1cm4gMDsKPiAtCWNhc2UgVElP Q1NTRVJJQUw6Cj4gLQkJaWYgKGNvcHlfZnJvbV91c2VyKCZzZXJzdHJ1Y3QsIHVzZXJfYXJnLCBz aXplb2Yoc2Vyc3RydWN0KSkpCj4gLQkJCXJldHVybiAtRUZBVUxUOwo+IC0JCXJldHVybiAwOwo+ ICsJZGVmYXVsdDoKPiArCQlicmVhazsKPiAgCX0KPiAgCj4gIAlyZXR1cm4gLUVOT0lPQ1RMQ01E OwoKVGhpcyB3aWxsIG1ha2UgdGhlIGlvY3RsIHJldHVybiAtRU5PVFRZIHRvIHVzZXIgc3BhY2Ug KGUuZy4gc2V0c2VyaWFsKSwKd2hpY2ggSSBndWVzcyBzaG91bGQgYmUgZmluZSBhcyBUSU9DU1NF UklBTCByZWFsbHkgaXNuJ3Qgc3VwcG9ydGVkIGZvcgp0aGVzZSBkZXZpY2VzIGN1cnJlbnRseS4K CkJ1dCB5b3Ugc2hvdWxkIGF0IGxlYXN0IG1lbnRpb24gdGhpcyBjaGFuZ2VkIGJlaGF2aW91ciBp biB0aGUgY29tbWl0Cm1lc3NhZ2UuCgpQbGVhc2UgYWxzbyBkcm9wIHRoZSAiLmMiIHBhcnQgZnJv bSB0aGUgc3ViamVjdCBwcmVmaXggd2hpbGUgYXQgaXQuCgpUaGFua3MsCkpvaGFuCi0tLQpUbyB1 bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGlu dXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVs Lm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9y ZG9tby1pbmZvLmh0bWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbeABOuu (ORCPT + 1 other); Tue, 2 Jan 2018 09:50:50 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:38014 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbeABOus (ORCPT ); Tue, 2 Jan 2018 09:50:48 -0500 X-Google-Smtp-Source: ACJfBovUVQcoT99SS8YZAsegt6l9VsCpnfhoBTCa2CVXn1C/UcKjjrUwqWzfp7gb5e++5exm4w0A8A== Date: Tue, 2 Jan 2018 15:50:47 +0100 From: Johan Hovold To: Mikhail Zaytsev Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] USB: serial: ark3116.c: Remove unused TIOCSSERIAL ioctl case. Message-ID: <20180102145047.GL16993@localhost> References: <20171213123004.4619000a@zaytsev.tver.pg> <20171213112445.GB3831@localhost> <20171213164455.11dd6f8b@zaytsev.tver.pg> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171213164455.11dd6f8b@zaytsev.tver.pg> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Wed, Dec 13, 2017 at 04:44:55PM +0300, Mikhail Zaytsev wrote: > The patch removes unused TIOCSSERIAL ioctl case and adds the default block > to the switch. > > Signed-off-by: Mikhail Zaytsev > --- > drivers/usb/serial/ark3116.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c > index 23d46ef87..2e957c76f 100644 > --- a/drivers/usb/serial/ark3116.c > +++ b/drivers/usb/serial/ark3116.c > @@ -418,10 +418,8 @@ static int ark3116_ioctl(struct tty_struct *tty, > return -EFAULT; > > return 0; > - case TIOCSSERIAL: > - if (copy_from_user(&serstruct, user_arg, sizeof(serstruct))) > - return -EFAULT; > - return 0; > + default: > + break; > } > > return -ENOIOCTLCMD; This will make the ioctl return -ENOTTY to user space (e.g. setserial), which I guess should be fine as TIOCSSERIAL really isn't supported for these devices currently. But you should at least mention this changed behaviour in the commit message. Please also drop the ".c" part from the subject prefix while at it. Thanks, Johan