From: Tejun Heo <tj@kernel.org>
To: Darren Stevens <darren@stevens-zone.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata:pata_atiixp: Don't use unconnected secondary port on SB600
Date: Tue, 2 Jan 2018 06:56:49 -0800 [thread overview]
Message-ID: <20180102145608.GA3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <4b3d1364126.4c1d107e@auth.smtp.1and1.co.uk>
Hello, Darren.
On Sun, Dec 31, 2017 at 09:11:05PM +0000, Darren Stevens wrote:
> The AMD SB600 southbridge has an PATA IDE interface, but the
> secondary port has no physical connections, so is disabled in
> the PCI header which makes it appear as a legacy port.
How sure are you about the secondary port never being used? Given the
age of the device and that this has been like this the whole time, I'd
prefer if the workaround were more specific - ie. mark it dummy only
on the specific machines that are known to be broken. That said, if
we know with certainty that the secondary port is never used, sure.
Thanks.
--
tejun
next prev parent reply other threads:[~2018-01-02 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-31 21:11 [PATCH] libata:pata_atiixp: Don't use unconnected secondary port on SB600 Darren Stevens
2018-01-02 14:56 ` Tejun Heo [this message]
2018-01-06 10:13 ` Darren Stevens
2018-01-08 12:02 ` [PATCH] " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102145608.GA3668920@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=darren@stevens-zone.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.