From: "Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>
To: Santosh Shilimkar
<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>,
Suman Anna <s-anna-l0cyMroinI0@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Andrew F . Davis" <afd-l0cyMroinI0@public.gmane.org>
Subject: [PATCH 6/8] ARM: dts: keystone-k2g: Move keystone_irq to under device-state-control
Date: Tue, 2 Jan 2018 11:02:00 -0600 [thread overview]
Message-ID: <20180102170202.15045-7-afd@ti.com> (raw)
In-Reply-To: <20180102170202.15045-1-afd-l0cyMroinI0@public.gmane.org>
The keystone_irq node describes a device that is a component of the device
state control module. As such, it should not be a member of soc0 bus
but instead a sub-node of device-state-control.
This move also fixes a warning about not having a reg property. Now
that this is a sub-node of device-state-control, a syscon type node,
we add this reg property but relative to the syscon base, this way
when the dt-binding/driver are updated we can drop the non-standard
ti,syscon-dev property completely and simply use get_resource() in
the driver.
Signed-off-by: Andrew F. Davis <afd-l0cyMroinI0@public.gmane.org>
Acked-by: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
---
arch/arm/boot/dts/keystone-k2g.dtsi | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/arch/arm/boot/dts/keystone-k2g.dtsi b/arch/arm/boot/dts/keystone-k2g.dtsi
index fd061718dc0a..19f938e3c27e 100644
--- a/arch/arm/boot/dts/keystone-k2g.dtsi
+++ b/arch/arm/boot/dts/keystone-k2g.dtsi
@@ -97,8 +97,19 @@
};
devctrl: device-state-control@2620000 {
- compatible = "ti,keystone-devctrl", "syscon";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "ti,keystone-devctrl", "syscon", "simple-mfd";
reg = <0x02620000 0x1000>;
+
+ kirq0: keystone_irq@2a0 {
+ compatible = "ti,keystone-irq";
+ reg = <0x2a0 0x10>;
+ interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ ti,syscon-dev = <&devctrl 0x2a0>;
+ };
};
uart0: serial@2530c00 {
@@ -188,14 +199,6 @@
status = "disabled";
};
- kirq0: keystone_irq@26202a0 {
- compatible = "ti,keystone-irq";
- interrupts = <GIC_SPI 1 IRQ_TYPE_EDGE_RISING>;
- interrupt-controller;
- #interrupt-cells = <1>;
- ti,syscon-dev = <&devctrl 0x2a0>;
- };
-
dspgpio0: keystone_dsp_gpio@2620240 {
compatible = "ti,keystone-dsp-gpio";
gpio-controller;
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-02 17:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 17:01 [PATCH 0/8] ARM: dts: keystone*: Continued warnings cleanups Andrew F. Davis
[not found] ` <20180102170202.15045-1-afd-l0cyMroinI0@public.gmane.org>
2018-01-02 17:01 ` [PATCH 1/8] ARM: dts: keystone: Move keystone_irq to under device-state-control Andrew F. Davis
2018-01-02 23:30 ` Suman Anna
2018-01-02 23:30 ` Suman Anna
2018-01-04 19:34 ` Andrew F. Davis
2018-01-04 19:34 ` Andrew F. Davis
2018-01-02 17:01 ` [PATCH 2/8] ARM: dts: keystone: Move reset-controller " Andrew F. Davis
2018-01-02 17:01 ` [PATCH 3/8] ARM: dts: keystone-k2e: Move keystone_dsp_gpio " Andrew F. Davis
2018-01-02 17:01 ` [PATCH 4/8] ARM: dts: keystone-k2l: " Andrew F. Davis
2018-01-02 17:01 ` [PATCH 5/8] ARM: dts: keystone-k2hk: " Andrew F. Davis
2018-01-02 17:02 ` Andrew F. Davis [this message]
2018-01-02 17:02 ` [PATCH 7/8] ARM: dts: keystone-k2g: " Andrew F. Davis
2018-01-02 17:02 ` [PATCH 8/8] ARM: dts: keystone-k2g: Move usb-phy nodes out of soc0 Andrew F. Davis
2018-01-04 19:10 ` [PATCH 0/8] ARM: dts: keystone*: Continued warnings cleanups Santosh Shilimkar
2018-01-04 19:10 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102170202.15045-7-afd@ti.com \
--to=afd-l0cymroini0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nm-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=s-anna-l0cyMroinI0@public.gmane.org \
--cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.