From: Vivek Goyal <vgoyal@redhat.com>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: linux-unionfs@vger.kernel.org, fstests@vger.kernel.org,
miklos@szeredi.hu, amir73il@gmail.com, eguan@redhat.com,
miaoxie@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH xfstest v2 2/4] overlay: add fsck.overlay whiteout test
Date: Tue, 2 Jan 2018 15:05:01 -0500 [thread overview]
Message-ID: <20180102200501.GD15274@redhat.com> (raw)
In-Reply-To: <20171228114933.47759-3-yi.zhang@huawei.com>
On Thu, Dec 28, 2017 at 07:49:31PM +0800, zhangyi (F) wrote:
[..]
> +# Create test directories
> +lowerdir=$OVL_BASE_SCRATCH_MNT/lower
> +lowerdir2=$OVL_BASE_SCRATCH_MNT/lower2
> +upperdir=$OVL_BASE_SCRATCH_MNT/upper
> +workdir=$OVL_BASE_SCRATCH_MNT/workdir
> +
> +mkdir -p $lowerdir $lowerdir2 $upperdir $workdir $workdir
Minor nit. Why $workdir has been specified twice. I saw it in another test
as well.
Vivek
next prev parent reply other threads:[~2018-01-02 20:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-28 11:49 [PATCH xfstest v2 0/4] overlay: add fsck.overlay basic tests zhangyi (F)
2017-12-28 11:49 ` [PATCH xfstest v2 1/4] overlay: add filesystem check helper zhangyi (F)
2017-12-28 12:12 ` Amir Goldstein
2017-12-28 11:49 ` [PATCH xfstest v2 2/4] overlay: add fsck.overlay whiteout test zhangyi (F)
2017-12-28 12:11 ` Amir Goldstein
2017-12-29 1:27 ` zhangyi (F)
2018-01-02 20:05 ` Vivek Goyal [this message]
2018-01-03 1:02 ` zhangyi (F)
2018-01-03 15:04 ` Vivek Goyal
2018-01-04 1:15 ` zhangyi (F)
2017-12-28 11:49 ` [PATCH xfstest v2 3/4] overlay: add fsck.overlay redirect directory test zhangyi (F)
2017-12-28 12:37 ` Amir Goldstein
2017-12-29 1:49 ` zhangyi (F)
2017-12-30 4:06 ` zhangyi (F)
2017-12-30 9:35 ` Amir Goldstein
2017-12-31 5:06 ` zhangyi
2017-12-28 11:49 ` [PATCH xfstest v2 4/4] overlay: add fsck.overlay impure xattr test zhangyi (F)
2017-12-28 12:43 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180102200501.GD15274@redhat.com \
--to=vgoyal@redhat.com \
--cc=amir73il@gmail.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=miklos@szeredi.hu \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.