Re: [PATCH] Improve compatibility with other platforms

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1569 bytes --]

On Tue, Jan 02, 2018 at 08:37:16PM -0600, Kyle Evans wrote:
> On Tue, Jan 2, 2018 at 6:13 PM, David Gibson
> <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> wrote:
> > On Sun, Dec 31, 2017 at 10:15:18PM -0600, kevans-HZy0K5TPuP5AfugRpC6u6w@public.gmane.org wrote:
> >> This doesn't make things work out of the box necessarily, but it gets us a step
> >> closer.
> >>
> >>  - alloca(3) on FreeBSD and OpenBSD, at least, is provided as part of
> >> <stdlib.h>. I make the change here for FreeBSD only, though, as I cannot test it
> >> on OpenBSD.
> >
> > TBH, rather than dicking around with #ifdefs and headers, I'd rather
> > use use malloc() instead of alloca().
> 
> Alrighty- I'll prepare a patch for this, knowing that's a direction
> you're comfortable heading in.
> 
> >>  - stat -c %s's equivalent on FreeBSD is stat -f %Uz; these differ enough, allow
> >> STATSZ in the environment to specify local replacement for a stat that outputs
> >> size in bytes of an argument.
> >
> > Can you split this change out into a separate patch, please.
> 
> Will do.

Fwiw, some years ago I did a bunch of work to get dtc to compile and
pass the tests on FreeBSD.  Working out of the box on *BSD is
something I'd like it to have.  Unfortunately, because I can't easily
test on a BSD machine, the BSD support tends to bitrot rather rapidly.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]