From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [LINUX,3/4] dmaengine: xilinx_dma: Fix compilation warning From: Vinod Koul Message-Id: <20180103035918.GH18649@localhost> Date: Wed, 3 Jan 2018 09:29:18 +0530 To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gVGh1LCBEZWMgMjEsIDIwMTcgYXQgMDM6NDE6MzdQTSArMDUzMCwgS2VkYXJlc3dhcmEgcmFv IEFwcGFuYSB3cm90ZToKCkZpeCB0aXRsZSBoZXJlIHRvbwoKQlRXIHdoYXRzIHdpdGggTElOVVgg dGFnIGluIHBhdGNoZXMsIHBscyBkcm9wIHRoZW0KCj4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgYmVs b3cgc3BhcnNlIHdhcm5pbmcgaW4gdGhlIGRyaXZlcgo+IGRyaXZlcnMvZG1hL3hpbGlueC94aWxp bnhfZG1hLmM6IEluIGZ1bmN0aW9uIOKAmHhpbGlueF92ZG1hX2RtYV9wcmVwX2ludGVybGVhdmVk 4oCZOgo+IGRyaXZlcnMvZG1hL3hpbGlueC94aWxpbnhfZG1hLmM6MTYxNDo0Mzogd2FybmluZzog dmFyaWFibGUg4oCYcHJlduKAmSBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZh cmlhYmxlXQo+ICAgc3RydWN0IHhpbGlueF92ZG1hX3R4X3NlZ21lbnQgKnNlZ21lbnQsICpwcmV2 ID0gTlVMTDsKPiAKPiBTaWduZWQtb2ZmLWJ5OiBLZWRhcmVzd2FyYSByYW8gQXBwYW5hIDxhcHBh bmFkQHhpbGlueC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hL3hpbGlueC94aWxpbnhfZG1hLmMg fCA0ICstLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAzIGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS94aWxpbngveGlsaW54X2RtYS5jIGIvZHJp dmVycy9kbWEveGlsaW54L3hpbGlueF9kbWEuYwo+IGluZGV4IDg0Njc2NzEuLjg0NWU2MzggMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEveGlsaW54L3hpbGlueF9kbWEuYwo+ICsrKyBiL2RyaXZl cnMvZG1hL3hpbGlueC94aWxpbnhfZG1hLmMKPiBAQCAtMTYxMSw3ICsxNjExLDcgQEAgeGlsaW54 X3ZkbWFfZG1hX3ByZXBfaW50ZXJsZWF2ZWQoc3RydWN0IGRtYV9jaGFuICpkY2hhbiwKPiAgewo+ ICAJc3RydWN0IHhpbGlueF9kbWFfY2hhbiAqY2hhbiA9IHRvX3hpbGlueF9jaGFuKGRjaGFuKTsK PiAgCXN0cnVjdCB4aWxpbnhfZG1hX3R4X2Rlc2NyaXB0b3IgKmRlc2M7Cj4gLQlzdHJ1Y3QgeGls aW54X3ZkbWFfdHhfc2VnbWVudCAqc2VnbWVudCwgKnByZXYgPSBOVUxMOwo+ICsJc3RydWN0IHhp bGlueF92ZG1hX3R4X3NlZ21lbnQgKnNlZ21lbnQ7Cj4gIAlzdHJ1Y3QgeGlsaW54X3ZkbWFfZGVz Y19odyAqaHc7Cj4gIAo+ICAJaWYgKCFpc19zbGF2ZV9kaXJlY3Rpb24oeHQtPmRpcikpCj4gQEAg LTE2NjUsOCArMTY2NSw2IEBAIHhpbGlueF92ZG1hX2RtYV9wcmVwX2ludGVybGVhdmVkKHN0cnVj dCBkbWFfY2hhbiAqZGNoYW4sCj4gIAkvKiBJbnNlcnQgdGhlIHNlZ21lbnQgaW50byB0aGUgZGVz Y3JpcHRvciBzZWdtZW50cyBsaXN0LiAqLwo+ICAJbGlzdF9hZGRfdGFpbCgmc2VnbWVudC0+bm9k ZSwgJmRlc2MtPnNlZ21lbnRzKTsKPiAgCj4gLQlwcmV2ID0gc2VnbWVudDsKPiAtCj4gIAkvKiBM aW5rIHRoZSBsYXN0IGhhcmR3YXJlIGRlc2NyaXB0b3Igd2l0aCB0aGUgZmlyc3QuICovCj4gIAlz ZWdtZW50ID0gbGlzdF9maXJzdF9lbnRyeSgmZGVzYy0+c2VnbWVudHMsCj4gIAkJCQkgICBzdHJ1 Y3QgeGlsaW54X3ZkbWFfdHhfc2VnbWVudCwgbm9kZSk7Cj4gLS0gCj4gMi43LjQKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Wed, 3 Jan 2018 09:29:18 +0530 Subject: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning In-Reply-To: <1513851098-15787-4-git-send-email-appanad@xilinx.com> References: <1513851098-15787-1-git-send-email-appanad@xilinx.com> <1513851098-15787-4-git-send-email-appanad@xilinx.com> Message-ID: <20180103035918.GH18649@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote: Fix title here too BTW whats with LINUX tag in patches, pls drop them > This patch fixes the below sparse warning in the driver > drivers/dma/xilinx/xilinx_dma.c: In function ?xilinx_vdma_dma_prep_interleaved?: > drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ?prev? set but not used [-Wunused-but-set-variable] > struct xilinx_vdma_tx_segment *segment, *prev = NULL; > > Signed-off-by: Kedareswara rao Appana > --- > drivers/dma/xilinx/xilinx_dma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 8467671..845e638 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > { > struct xilinx_dma_chan *chan = to_xilinx_chan(dchan); > struct xilinx_dma_tx_descriptor *desc; > - struct xilinx_vdma_tx_segment *segment, *prev = NULL; > + struct xilinx_vdma_tx_segment *segment; > struct xilinx_vdma_desc_hw *hw; > > if (!is_slave_direction(xt->dir)) > @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > /* Insert the segment into the descriptor segments list. */ > list_add_tail(&segment->node, &desc->segments); > > - prev = segment; > - > /* Link the last hardware descriptor with the first. */ > segment = list_first_entry(&desc->segments, > struct xilinx_vdma_tx_segment, node); > -- > 2.7.4 > -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751815AbeACDzP (ORCPT + 1 other); Tue, 2 Jan 2018 22:55:15 -0500 Received: from mga11.intel.com ([192.55.52.93]:28955 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbeACDzO (ORCPT ); Tue, 2 Jan 2018 22:55:14 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,500,1508828400"; d="scan'208";a="23768353" Date: Wed, 3 Jan 2018 09:29:18 +0530 From: Vinod Koul To: Kedareswara rao Appana Cc: dan.j.williams@intel.com, michal.simek@xilinx.com, appanad@xilinx.com, lars@metafoo.de, akinobu.mita@gmail.com, joabreu@synopsys.com, mike.looijmans@topic.nl, kedare06@gmail.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [LINUX PATCH 3/4] dmaengine: xilinx_dma: Fix compilation warning Message-ID: <20180103035918.GH18649@localhost> References: <1513851098-15787-1-git-send-email-appanad@xilinx.com> <1513851098-15787-4-git-send-email-appanad@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1513851098-15787-4-git-send-email-appanad@xilinx.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thu, Dec 21, 2017 at 03:41:37PM +0530, Kedareswara rao Appana wrote: Fix title here too BTW whats with LINUX tag in patches, pls drop them > This patch fixes the below sparse warning in the driver > drivers/dma/xilinx/xilinx_dma.c: In function ‘xilinx_vdma_dma_prep_interleaved’: > drivers/dma/xilinx/xilinx_dma.c:1614:43: warning: variable ‘prev’ set but not used [-Wunused-but-set-variable] > struct xilinx_vdma_tx_segment *segment, *prev = NULL; > > Signed-off-by: Kedareswara rao Appana > --- > drivers/dma/xilinx/xilinx_dma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index 8467671..845e638 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1611,7 +1611,7 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > { > struct xilinx_dma_chan *chan = to_xilinx_chan(dchan); > struct xilinx_dma_tx_descriptor *desc; > - struct xilinx_vdma_tx_segment *segment, *prev = NULL; > + struct xilinx_vdma_tx_segment *segment; > struct xilinx_vdma_desc_hw *hw; > > if (!is_slave_direction(xt->dir)) > @@ -1665,8 +1665,6 @@ xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > /* Insert the segment into the descriptor segments list. */ > list_add_tail(&segment->node, &desc->segments); > > - prev = segment; > - > /* Link the last hardware descriptor with the first. */ > segment = list_first_entry(&desc->segments, > struct xilinx_vdma_tx_segment, node); > -- > 2.7.4 > -- ~Vinod